Commit 413cdda9 authored by rch's avatar rch Committed by Commit bot

Fix bug in ALTERNATE_PROTOCOL_USAGE_MAPPING_MISSING histogram

in which we would consider the mapping to be missing even if
the probability was such that we would not honor the advertisement.

BUG=

Review URL: https://codereview.chromium.org/620753007

Cr-Commit-Position: refs/heads/master@{#297773}
parent c9089fa2
......@@ -283,11 +283,13 @@ void HttpServerPropertiesImpl::SetAlternateProtocol(
<< "].";
}
} else {
// TODO(rch): Consider the case where multiple requests are started
// before the first completes. In this case, only one of the jobs
// would reach this code, whereas all of them should should have.
HistogramAlternateProtocolUsage(ALTERNATE_PROTOCOL_USAGE_MAPPING_MISSING,
alternate_protocol_experiment_);
if (alternate_probability >= alternate_protocol_probability_threshold_) {
// TODO(rch): Consider the case where multiple requests are started
// before the first completes. In this case, only one of the jobs
// would reach this code, whereas all of them should should have.
HistogramAlternateProtocolUsage(ALTERNATE_PROTOCOL_USAGE_MAPPING_MISSING,
alternate_protocol_experiment_);
}
}
alternate_protocol_map_.Put(server, alternate);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment