Commit 414dd168 authored by changwan@chromium.org's avatar changwan@chromium.org

ToolbarModel::GetText() returns not only search terms but also formatted URL.

Android does not use location_bar_view but its own LocationBarView, and this
still requires access to ToolbarModel::GetText() to show formatted URL
to its users. We need to reuse GetText() to get formatted URL.
    
BUG=365567,293227

Review URL: https://codereview.chromium.org/251983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270027 0039d316-1c4b-4281-b951-d872f2087c98
parent 6b4656a5
...@@ -42,10 +42,10 @@ public class ToolbarModel { ...@@ -42,10 +42,10 @@ public class ToolbarModel {
mNativeToolbarModelAndroid = 0; mNativeToolbarModelAndroid = 0;
} }
/** @return The search terms extracted from the current url if query extraction is enabled. */ /** @return The formatted text (URL or search terms) for display. */
public String getSearchTerms() { public String getText() {
if (mNativeToolbarModelAndroid == 0) return null; if (mNativeToolbarModelAndroid == 0) return null;
return nativeGetSearchTerms(mNativeToolbarModelAndroid); return nativeGetText(mNativeToolbarModelAndroid);
} }
/** @return The parameter in the url that triggers query extraction. */ /** @return The parameter in the url that triggers query extraction. */
...@@ -62,7 +62,7 @@ public class ToolbarModel { ...@@ -62,7 +62,7 @@ public class ToolbarModel {
private native long nativeInit(ToolbarModelDelegate delegate); private native long nativeInit(ToolbarModelDelegate delegate);
private native void nativeDestroy(long nativeToolbarModelAndroid); private native void nativeDestroy(long nativeToolbarModelAndroid);
private native String nativeGetSearchTerms(long nativeToolbarModelAndroid); private native String nativeGetText(long nativeToolbarModelAndroid);
private native String nativeGetQueryExtractionParam(long nativeToolbarModelAndroid); private native String nativeGetQueryExtractionParam(long nativeToolbarModelAndroid);
private native String nativeGetCorpusChipText(long nativeToolbarModelAndroid); private native String nativeGetCorpusChipText(long nativeToolbarModelAndroid);
} }
...@@ -26,8 +26,8 @@ void ToolbarModelAndroid::Destroy(JNIEnv* env, jobject obj) { ...@@ -26,8 +26,8 @@ void ToolbarModelAndroid::Destroy(JNIEnv* env, jobject obj) {
delete this; delete this;
} }
ScopedJavaLocalRef<jstring> ToolbarModelAndroid::GetSearchTerms(JNIEnv* env, ScopedJavaLocalRef<jstring> ToolbarModelAndroid::GetText(JNIEnv* env,
jobject obj) { jobject obj) {
return base::android::ConvertUTF16ToJavaString(env, return base::android::ConvertUTF16ToJavaString(env,
toolbar_model_->GetText()); toolbar_model_->GetText());
} }
......
...@@ -24,7 +24,7 @@ class ToolbarModelAndroid : public ToolbarModelDelegate { ...@@ -24,7 +24,7 @@ class ToolbarModelAndroid : public ToolbarModelDelegate {
virtual ~ToolbarModelAndroid(); virtual ~ToolbarModelAndroid();
void Destroy(JNIEnv* env, jobject obj); void Destroy(JNIEnv* env, jobject obj);
base::android::ScopedJavaLocalRef<jstring> GetSearchTerms( base::android::ScopedJavaLocalRef<jstring> GetText(
JNIEnv* env, JNIEnv* env,
jobject obj); jobject obj);
base::android::ScopedJavaLocalRef<jstring> GetQueryExtractionParam( base::android::ScopedJavaLocalRef<jstring> GetQueryExtractionParam(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment