Commit 41ab6a55 authored by Alex Cooper's avatar Alex Cooper Committed by Commit Bot

Adjust when WebXr timeouts run

There seems to be an issue with starting up the "timed out" UI when a
notifications prompt is visible or needs to be dismissed.  This modifies
the behavior of SetFramesThrottled to only stop/start the timeouts if a
webxr frame has not yet been submitted.  This is essentially the logic
that existed for these timeouts prior to the implementation of the
throttled logic.

Bug: 1014764
Change-Id: Ia9646799b8d54efc1f39e8800bf82acc5cf861a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865810
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: default avatarKlaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706681}
parent 418f4c4e
...@@ -173,6 +173,12 @@ void VRBrowserRendererThreadWin::SetFramesThrottled(bool throttled) { ...@@ -173,6 +173,12 @@ void VRBrowserRendererThreadWin::SetFramesThrottled(bool throttled) {
if (g_frame_timeout_ui_disabled_for_testing_) if (g_frame_timeout_ui_disabled_for_testing_)
return; return;
// TODO(crbug.com/1014764): If we try to re-start the timeouts after UI has
// already been shown (e.g. a user takes their headset off for a permissions
// prompt). Then the prompt UI doesn't seem to be dismissed immediately.
if (!waiting_for_webxr_frame_)
return;
if (frames_throttled_) { if (frames_throttled_) {
StopWebXrTimeout(); StopWebXrTimeout();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment