Remove obsolete launcher histograms.

This removes these two histograms and the logic related to them:
 Apps.AppListResultLaunchIndexAndQueryLength
 Apps.AppListResultLaunchIsEmptyQuery

Bug: 1160781
Change-Id: Ifcd61df6a40dc6bb910bc7c2a6d27e83a0f84cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628869Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844957}

ash/app_list/app_list_controller_impl.cc

@@ -1114,13 +1114,6 @@ void AppListControllerImpl::OpenSearchResult(const std::string& result_id,
   ResetHomeLauncherIfShown();
 }
 
-void AppListControllerImpl::LogResultLaunchHistogram(
-    SearchResultLaunchLocation launch_location,
-    int suggestion_index) {
-  RecordSearchLaunchIndexAndQueryLength(launch_location, GetLastQueryLength(),
-                                        suggestion_index);
-}
-
 void AppListControllerImpl::LogSearchAbandonHistogram() {
   RecordSearchAbandonWithQueryLengthHistogram(GetLastQueryLength());
 }

ash/app_list/app_list_controller_impl.h

@@ -173,8 +173,6 @@ class ASH_EXPORT AppListControllerImpl
                         AppListLaunchType launch_type,
                         int suggestion_index,
                         bool launch_as_default) override;
-  void LogResultLaunchHistogram(SearchResultLaunchLocation launch_location,
-                                int suggestion_index) override;
   void LogSearchAbandonHistogram() override;
   void InvokeSearchResultAction(const std::string& result_id,
                                 int action_index) override;

ash/app_list/app_list_controller_impl_unittest.cc

@@ -108,11 +108,6 @@ aura::Window* GetAppListViewNativeWindow() {
   return GetAppListView()->GetWidget()->GetNativeView();
 }
 
-void SetSearchText(AppListControllerImpl* controller, const std::string& text) {
-  controller->GetSearchModel()->search_box()->Update(base::ASCIIToUTF16(text),
-                                                     false);
-}
-
 }  // namespace
 
 class AppListControllerImplTest : public AshTestBase {
@@ -1114,39 +1109,6 @@ class AppListControllerImplMetricsTest : public AshTestBase {
   DISALLOW_COPY_AND_ASSIGN(AppListControllerImplMetricsTest);
 };
 
-TEST_F(AppListControllerImplMetricsTest, LogSingleResultListClick) {
-  histogram_tester_.ExpectTotalCount(kAppListResultLaunchIndexAndQueryLength,
-                                     0);
-  SetSearchText(controller_, "");
-  controller_->LogResultLaunchHistogram(SearchResultLaunchLocation::kResultList,
-                                        4);
-  histogram_tester_.ExpectUniqueSample(kAppListResultLaunchIndexAndQueryLength,
-                                       4, 1);
-}
-
-TEST_F(AppListControllerImplMetricsTest, LogOneClickInEveryBucket) {
-  histogram_tester_.ExpectTotalCount(kAppListResultLaunchIndexAndQueryLength,
-                                     0);
-  for (int query_length = 0; query_length < 11; ++query_length) {
-    const std::string query(query_length, 'a');
-    for (int click_index = 0; click_index < 7; ++click_index) {
-      SetSearchText(controller_, query);
-      controller_->LogResultLaunchHistogram(
-          SearchResultLaunchLocation::kResultList, click_index);
-    }
-  }
-
-  histogram_tester_.ExpectTotalCount(kAppListResultLaunchIndexAndQueryLength,
-                                     77);
-  for (int query_length = 0; query_length < 11; ++query_length) {
-    for (int click_index = 0; click_index < 7; ++click_index) {
-      histogram_tester_.ExpectBucketCount(
-          kAppListResultLaunchIndexAndQueryLength,
-          7 * query_length + click_index, 1);
-    }
-  }
-}
-
 // One edge case may do harm to the presentation metrics reporter for tablet
 // mode: the user may keep pressing on launcher while exiting the tablet mode by
 // rotating the lid. In this situation, OnHomeLauncherDragEnd is not triggered.

ash/app_list/app_list_metrics.cc

@@ -16,18 +16,12 @@
 #include "ui/compositor/compositor.h"
 
 namespace ash {
-
 namespace {
 
-// These constants affect logging, and  should not be changed without
-// deprecating the following UMA histograms:
-//  - Apps.AppListTileClickIndexAndQueryLength
-//  - Apps.AppListResultClickIndexAndQueryLength
+// This constant affects logging, and should not be changed without
+// deprecating this UMA histogram:
+//  - Apps.AppListSearchAbandonQueryLength
 constexpr int kMaxLoggedQueryLength = 10;
-constexpr int kMaxLoggedSuggestionIndex = 6;
-constexpr int kMaxLoggedHistogramValue =
-    (kMaxLoggedSuggestionIndex + 1) * kMaxLoggedQueryLength +
-    kMaxLoggedSuggestionIndex;
 
 }  // namespace
 
@@ -160,27 +154,6 @@ APP_LIST_EXPORT void RecordSearchResultOpenSource(
       ApplistSearchResultOpenedSource::kMaxApplistSearchResultOpenedSource);
 }
 
-void RecordSearchLaunchIndexAndQueryLength(
-    SearchResultLaunchLocation launch_location,
-    int query_length,
-    int suggestion_index) {
-  if (suggestion_index < 0) {
-    LOG(ERROR) << "Received invalid suggestion index.";
-    return;
-  }
-
-  query_length = std::min(query_length, kMaxLoggedQueryLength);
-  suggestion_index = std::min(suggestion_index, kMaxLoggedSuggestionIndex);
-  const int logged_value =
-      (kMaxLoggedSuggestionIndex + 1) * query_length + suggestion_index;
-
-  if (launch_location == SearchResultLaunchLocation::kResultList) {
-    UMA_HISTOGRAM_EXACT_LINEAR(kAppListResultLaunchIndexAndQueryLength,
-                               logged_value, kMaxLoggedHistogramValue);
-    UMA_HISTOGRAM_BOOLEAN(kAppListResultLaunchIsEmptyQuery, query_length == 0);
-  }
-}
-
 void RecordSearchAbandonWithQueryLengthHistogram(int query_length) {
   UMA_HISTOGRAM_EXACT_LINEAR(kSearchAbandonQueryLengthHistogram,
                              std::min(query_length, kMaxLoggedQueryLength),

ash/app_list/app_list_metrics.h

@@ -64,16 +64,6 @@ constexpr char kAppListPeekingToFullscreenHistogram[] =
 // The UMA histogram that logs how the app list is shown.
 constexpr char kAppListToggleMethodHistogram[] = "Apps.AppListShowSource";
 
-// The UMA histogram that logs the index launched item in the results list and
-// the query length.
-constexpr char kAppListResultLaunchIndexAndQueryLength[] =
-    "Apps.AppListResultLaunchIndexAndQueryLength";
-
-// The UMA histogram that logs if the query that introduces a launch of an item
-// in the results list is empty or not.
-constexpr char kAppListResultLaunchIsEmptyQuery[] =
-    "Apps.AppListResultLaunchIsEmptyQuery";
-
 // The UMA histogram that logs the presence or absence of Drive QuickAccess
 // search results in the zero-state results list. Differentiates between results
 // existing in the model's results list, but not being displayed in the view.

ash/app_list/app_list_view_delegate.h

@@ -75,16 +75,6 @@ class ASH_PUBLIC_EXPORT AppListViewDelegate {
                                 int suggestion_index,
                                 bool launch_as_default) = 0;
 
-  // Called to log UMA metrics for the launch of an item either in the app tile
-  // list or the search result list. The |launch_location| argument determines
-  // which histogram to log to. |suggestion_index| represents the index of the
-  // launched item in its list view, not the overall position in the suggestion
-  // window. For instance, the first launcher result item is index 0, regardless
-  // of if there is an answer card above it.
-  virtual void LogResultLaunchHistogram(
-      SearchResultLaunchLocation launch_location,
-      int suggestion_index) = 0;
-
   // Logs the UMA histogram metrics for user's abandonment of launcher search.
   virtual void LogSearchAbandonHistogram() = 0;
 

ash/app_list/test/app_list_test_view_delegate.h

@@ -69,8 +69,6 @@ class AppListTestViewDelegate : public AppListViewDelegate,
                         ash::AppListLaunchType launch_type,
                         int suggestion_index,
                         bool launch_as_default) override;
-  void LogResultLaunchHistogram(SearchResultLaunchLocation launch_location,
-                                int suggestion_index) override {}
   void LogSearchAbandonHistogram() override {}
   void InvokeSearchResultAction(const std::string& result_id,
                                 int action_index) override {}

ash/app_list/views/search_result_list_view.cc

@@ -179,8 +179,6 @@ void SearchResultListView::SearchResultActivated(SearchResultView* view,
 
   RecordSearchResultOpenSource(result, view_delegate_->GetModel(),
                                view_delegate_->GetSearchModel());
-  view_delegate_->LogResultLaunchHistogram(
-      SearchResultLaunchLocation::kResultList, view->index_in_container());
   view_delegate_->NotifySearchResultsForLogging(
       view_delegate_->GetSearchModel()->search_box()->text(),
       GetSearchResultsForLogging(search_result_views_),

tools/metrics/histograms/histograms_xml/apps/histograms.xml

@@ -938,6 +938,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
 
 <histogram name="Apps.AppListResultLaunchIndexAndQueryLength" units="units"
     expires_after="2021-01-31">
+  <obsolete>
+    Removed January 2021.
+  </obsolete>
   <owner>tby@chromium.org</owner>
   <owner>thanhdng@chromium.org</owner>
   <summary>
@@ -949,6 +952,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
 
 <histogram name="Apps.AppListResultLaunchIsEmptyQuery" enum="Boolean"
     expires_after="2021-11-15">
+  <obsolete>
+    Removed January 2021.
+  </obsolete>
   <owner>thanhdng@chromium.org</owner>
   <owner>tby@chromium.org</owner>
   <summary>