Commit 41f021e6 authored by Jeremy Roman's avatar Jeremy Roman Committed by Commit Bot

Use find-only GetEventListener for removeEventListener.

This was erroneously picked up by the Blink reformat; the method name is still
lowercase at this point, so we were generating a find-and-create call when a
find-only call suffices.

https://chromium.googlesource.com/chromium/src/+/1c4d759e

Tested by manually inspecting generator output.

Change-Id: Ic7b6a4936b8bb7558e0ca21eddee23ca84348647
Reviewed-on: https://chromium-review.googlesource.com/599000Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarAdithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491558}
parent f429b926
......@@ -146,7 +146,7 @@ if (UNLIKELY(numArgsPassed <= {{argument.index}})) {
{% if argument.is_callback_interface %}
{# FIXME: remove EventListener/NodeFilter special case. crbug.com/630986 #}
{% if argument.idl_type == 'EventListener' %}
{% if method.name == 'RemoveEventListener' or method.name == 'RemoveListener' %}
{% if method.name == 'removeEventListener' or method.name == 'removeListener' %}
{{argument.name}} = V8EventListenerHelper::GetEventListener(ScriptState::Current(info.GetIsolate()), info[{{argument.index}}], false, kListenerFindOnly);
{% else %}{# method.name == 'AddEventListener' #}
{{argument.name}} = V8EventListenerHelper::GetEventListener(ScriptState::Current(info.GetIsolate()), info[{{argument.index}}], false, kListenerFindOrCreate);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment