Commit 41f36f62 authored by Peter Boström's avatar Peter Boström Committed by Commit Bot

Animate loading progress slower while loading

Makes the loading-progress animation smoother for pages that have not
finished loading pretty-much instantly. A follow-up might consider
removing actual loading progress completely and just animate to 70%
slowly until loading finishes.

Bug: chromium:908920
Change-Id: I207d602c1552591396840c346e88b0962af07be2
Reviewed-on: https://chromium-review.googlesource.com/c/1358923Reviewed-by: default avatarSidney San Martín <sdy@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613199}
parent 743db114
......@@ -27,7 +27,8 @@
namespace {
constexpr int kLoadingProgressTimeMs = 400;
constexpr int kSlowLoadingProgressTimeMs = 2000;
constexpr int kFastLoadingProgressTimeMs = 400;
constexpr int kLoadingProgressFadeOutMs = 200;
constexpr int kFaviconFadeInMs = 500;
......@@ -237,7 +238,10 @@ void TabIcon::UpdatePendingAnimationState() {
pending_animation_state_.elapsed_time = waiting_state_.elapsed_time;
if (pending_animation_state_.loading_progress) {
double loading_progress_delta = animation_delta_ms / kLoadingProgressTimeMs;
double loading_progress_delta =
animation_delta_ms / (network_state_ == TabNetworkState::kLoading
? kSlowLoadingProgressTimeMs
: kFastLoadingProgressTimeMs);
// Clamp the progress bar to the current target percentage.
pending_animation_state_.loading_progress = std::min(
*pending_animation_state_.loading_progress + loading_progress_delta,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment