Commit 42080a57 authored by Adrienne Walker's avatar Adrienne Walker Committed by Commit Bot

cc: Clean up TileManager initialization TODO

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I679c25020c26d987588f56641554cdb13b22ce49
Reviewed-on: https://chromium-review.googlesource.com/985242Reviewed-by: default avatarvmpstr <vmpstr@chromium.org>
Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547093}
parent 25671885
......@@ -46,7 +46,6 @@ FakeTileManager::FakeTileManager(TileManagerClient* client,
SetDecodedImageTracker(&decoded_image_tracker_);
SetResources(resource_pool, &image_decode_cache_, GetGlobalTaskGraphRunner(),
GetGlobalRasterBufferProvider(),
std::numeric_limits<size_t>::max(),
false /* use_gpu_rasterization */);
SetTileTaskManagerForTesting(std::make_unique<FakeTileTaskManagerImpl>());
}
......
......@@ -415,13 +415,11 @@ void TileManager::SetResources(ResourcePool* resource_pool,
ImageDecodeCache* image_decode_cache,
TaskGraphRunner* task_graph_runner,
RasterBufferProvider* raster_buffer_provider,
size_t scheduled_raster_task_limit,
bool use_gpu_rasterization) {
DCHECK(!tile_task_manager_);
DCHECK(task_graph_runner);
use_gpu_rasterization_ = use_gpu_rasterization;
scheduled_raster_task_limit_ = scheduled_raster_task_limit;
resource_pool_ = resource_pool;
image_controller_.SetImageDecodeCache(image_decode_cache);
tile_task_manager_ = TileTaskManagerImpl::Create(task_graph_runner);
......
......@@ -156,7 +156,6 @@ class CC_EXPORT TileManager : CheckerImageTrackerClient {
ImageDecodeCache* image_decode_cache,
TaskGraphRunner* task_graph_runner,
RasterBufferProvider* raster_buffer_provider,
size_t scheduled_raster_task_limit,
bool use_gpu_rasterization);
// This causes any completed raster work to finalize, so that tiles get up to
......
......@@ -2611,12 +2611,8 @@ void LayerTreeHostImpl::CreateTileManagerResources() {
task_graph_runner = single_thread_synchronous_task_graph_runner_.get();
}
// TODO(vmpstr): Initialize tile task limit at ctor time.
tile_manager_.SetResources(resource_pool_.get(), image_decode_cache_.get(),
task_graph_runner, raster_buffer_provider_.get(),
is_synchronous_single_threaded_
? std::numeric_limits<size_t>::max()
: settings_.scheduled_raster_task_limit,
use_gpu_rasterization_);
tile_manager_.SetCheckerImagingForceDisabled(
settings_.only_checker_images_with_gpu_raster && !use_gpu_rasterization_);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment