About WebUI: when showing about page, indicate that in page title

Bug: 870460
Change-Id: I1c8e20231d88fb7cb87b1bb2a31b6edcb031f6aa
Reviewed-on: https://chromium-review.googlesource.com/c/1313751
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604796}

chrome/app/settings_strings.grdp

@@ -603,6 +603,9 @@
   <message name="IDS_SETTINGS_SETTINGS" desc="The settings page title.">
     Settings
   </message>
+  <message name="IDS_SETTINGS_ALT_PAGE_TITLE" desc="The settings page title for the about page.">
+    Settings - <ph name="SECTION_TITLE">$1<ex>About Chromium</ex></ph>
+  </message>
   <if expr="not chromeos">
     <message name="IDS_SETTINGS_RESTART" desc="Text for a button that will restart Chrome.">
       Relaunch

chrome/browser/resources/settings/settings_main/settings_main.js

@@ -184,6 +184,12 @@ Polymer({
     const inAbout = settings.routes.ABOUT.contains(settings.getCurrentRoute());
     this.showPages_ = {about: inAbout, settings: !inAbout};
 
+    document.title = inAbout ?
+        loadTimeData.getStringF(
+            'settingsAltPageTitle', loadTimeData.getString('aboutPageTitle')) :
+        loadTimeData.getString('settings');
+
+
     // Calculate and set the overflow padding.
     this.updateOverscrollForPage_();
 

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -148,6 +148,7 @@ void AddCommonStrings(content::WebUIDataSource* html_source, Profile* profile) {
     {"retry", IDS_SETTINGS_RETRY},
     {"save", IDS_SAVE},
     {"settings", IDS_SETTINGS_SETTINGS},
+    {"settingsAltPageTitle", IDS_SETTINGS_ALT_PAGE_TITLE},
     {"toggleOn", IDS_SETTINGS_TOGGLE_ON},
     {"toggleOff", IDS_SETTINGS_TOGGLE_OFF},
     {"notValid", IDS_SETTINGS_NOT_VALID},