Cros: Fix unnecesary ripples on system tray when dragging hotseat

This changes the InkDropMode of several buttons in the System Tray from
ON to ON_NO_GESTURE_HANDLER to stop showing the ripple for gesture
events.

Fixed: 1012822
Change-Id: I4a004c7db4d45ce67f25f0f8de4257beb5d51d49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877450Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710923}

ash/system/accessibility/dictation_button_tray.cc

@@ -25,8 +25,6 @@ DictationButtonTray::DictationButtonTray(Shelf* shelf)
     : TrayBackgroundView(shelf), icon_(new views::ImageView()) {
   UpdateVisibility();
 
-  SetInkDropMode(InkDropMode::ON);
-
   off_image_ = gfx::CreateVectorIcon(kDictationOffNewuiIcon,
                                      ShelfConfig::Get()->shelf_icon_color());
   on_image_ = gfx::CreateVectorIcon(kDictationOnNewuiIcon,

ash/system/accessibility/select_to_speak_tray.cc

@@ -30,7 +30,6 @@ const char kSelectToSpeakTrayClassName[] =
 
 SelectToSpeakTray::SelectToSpeakTray(Shelf* shelf)
     : TrayBackgroundView(shelf), icon_(new views::ImageView()) {
-  SetInkDropMode(InkDropMode::ON);
 
   UpdateIconsForSession();
   icon_->SetImage(inactive_image_);

ash/system/ime_menu/ime_menu_tray.cc

@@ -335,7 +335,6 @@ ImeMenuTray::ImeMenuTray(Shelf* shelf)
       is_handwriting_enabled_(false),
       is_voice_enabled_(false) {
   DCHECK(ime_controller_);
-  SetInkDropMode(InkDropMode::ON);
   CreateLabel();
   SystemTrayNotifier* tray_notifier = Shell::Get()->system_tray_notifier();
   tray_notifier->AddIMEObserver(this);

ash/system/overview/overview_button_tray.cc

@@ -35,8 +35,6 @@ OverviewButtonTray::OverviewButtonTray(Shelf* shelf)
     : TrayBackgroundView(shelf),
       icon_(new views::ImageView()),
       scoped_session_observer_(this) {
-  SetInkDropMode(InkDropMode::ON);
-
   gfx::ImageSkia image = gfx::CreateVectorIcon(
       kShelfOverviewIcon, ShelfConfig::Get()->shelf_icon_color());
   icon_->SetImage(image);

ash/system/palette/palette_tray.cc

@@ -180,7 +180,6 @@ PaletteTray::PaletteTray(Shelf* shelf)
       scoped_session_observer_(this) {
   PaletteTool::RegisterToolInstances(palette_tool_manager_.get());
 
-  SetInkDropMode(InkDropMode::ON);
   SetLayoutManager(std::make_unique<views::FillLayout>());
   icon_ = new views::ImageView();
   icon_->set_tooltip_text(

ash/system/tray/status_area_overflow_button_tray.cc

@@ -83,8 +83,6 @@ void StatusAreaOverflowButtonTray::IconView::UpdateRotation() {
 
 StatusAreaOverflowButtonTray::StatusAreaOverflowButtonTray(Shelf* shelf)
     : TrayBackgroundView(shelf), icon_(new IconView()) {
-  SetInkDropMode(InkDropMode::ON);
-
   tray_container()->AddChildView(icon_);
 }
 

ash/system/tray/tray_background_view.cc

@@ -155,6 +155,7 @@ TrayBackgroundView::TrayBackgroundView(Shelf* shelf)
   set_ink_drop_visible_opacity(
       ShelfConfig::Get()->shelf_ink_drop_visible_opacity());
 
+  SetInkDropMode(InkDropMode::ON_NO_GESTURE_HANDLER);
   SetLayoutManager(std::make_unique<views::FillLayout>());
   SetInstallFocusRingOnFocus(true);
   focus_ring()->SetColor(ShelfConfig::Get()->shelf_focus_border_color());

ash/system/unified/unified_system_tray.cc

@@ -152,7 +152,6 @@ UnifiedSystemTray::UnifiedSystemTray(Shelf* shelf)
   tray_container()->AddChildView(new tray::PowerTrayView(shelf));
   tray_container()->AddChildView(time_view_);
 
-  SetInkDropMode(InkDropMode::ON);
   set_separator_visibility(false);
 
   ShelfConfig::Get()->AddObserver(this);

ash/system/virtual_keyboard/virtual_keyboard_tray.cc

@@ -29,8 +29,6 @@ namespace ash {
 
 VirtualKeyboardTray::VirtualKeyboardTray(Shelf* shelf)
     : TrayBackgroundView(shelf), icon_(new views::ImageView), shelf_(shelf) {
-  SetInkDropMode(InkDropMode::ON);
-
   UpdateIcon();
   tray_container()->AddChildView(icon_);