Commit 425d9b4a authored by Maxime Charland's avatar Maxime Charland Committed by Commit Bot

Add Feature flag for new Chrome Empties UI

This flag will be used to show or hide the new UI in Chrome empty states.

Bug: 1086688
Change-Id: I885d642f1f2e87f9b3b3346f3c1c7f8f80f064dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216547
Commit-Queue: Maxime Charland <mcharland@google.com>
Reviewed-by: default avatarTommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773786}
parent 27c34e42
...@@ -2766,6 +2766,11 @@ ...@@ -2766,6 +2766,11 @@
// testing and should not be removed. // testing and should not be removed.
"expiry_milestone": -1 "expiry_milestone": -1
}, },
{
"name": "illustrated-empty-states",
"owners": [ "mcharland", "tmartino" ],
"expiry_milestone": 88
},
{ {
"name": "improved-cookie-controls", "name": "improved-cookie-controls",
"owners": [ "dullweber", "huanzhong" ], "owners": [ "dullweber", "huanzhong" ],
......
...@@ -642,6 +642,9 @@ const flags_ui::FeatureEntry kFeatureEntries[] = { ...@@ -642,6 +642,9 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
flags_ui::kOsIos, flags_ui::kOsIos,
FEATURE_VALUE_TYPE( FEATURE_VALUE_TYPE(
autofill::features::kAutofillEnableCardNicknameUpstream)}, autofill::features::kAutofillEnableCardNicknameUpstream)},
{"illustrated-empty-states", flag_descriptions::kIllustratedEmptyStatesName,
flag_descriptions::kIllustratedEmptyStatesDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kIllustratedEmptyStates)},
}; };
bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) { bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) {
......
...@@ -257,6 +257,10 @@ const char kFullscreenControllerBrowserScopedDescription[] = ...@@ -257,6 +257,10 @@ const char kFullscreenControllerBrowserScopedDescription[] =
"When enabled, FullscreenController will be stored and retrieved using the " "When enabled, FullscreenController will be stored and retrieved using the "
"Browser."; "Browser.";
const char kIllustratedEmptyStatesName[] = "Illustrated empty states";
const char kIllustratedEmptyStatesDescription[] =
"Display new illustrations and layout on empty states.";
const char kInfobarOverlayUIName[] = "Use OverlayPresenter for infobars"; const char kInfobarOverlayUIName[] = "Use OverlayPresenter for infobars";
const char kInfobarOverlayUIDescription[] = const char kInfobarOverlayUIDescription[] =
"When enabled alongside the Infobar UI Reboot, infobars will be presented " "When enabled alongside the Infobar UI Reboot, infobars will be presented "
......
...@@ -222,6 +222,11 @@ extern const char kFullscreenSmoothScrollingDescription[]; ...@@ -222,6 +222,11 @@ extern const char kFullscreenSmoothScrollingDescription[];
extern const char kFullscreenControllerBrowserScopedName[]; extern const char kFullscreenControllerBrowserScopedName[];
extern const char kFullscreenControllerBrowserScopedDescription[]; extern const char kFullscreenControllerBrowserScopedDescription[];
// Title and description for the flag to enable new illustrations and
// UI on empty states.
extern const char kIllustratedEmptyStatesName[];
extern const char kIllustratedEmptyStatesDescription[];
// Title and description for the flag to present the new UI Reboot on Infobars // Title and description for the flag to present the new UI Reboot on Infobars
// using OverlayPresenter. // using OverlayPresenter.
extern const char kInfobarOverlayUIName[]; extern const char kInfobarOverlayUIName[];
......
...@@ -56,3 +56,6 @@ const base::Feature kEnableIOSManagedSettingsUI{ ...@@ -56,3 +56,6 @@ const base::Feature kEnableIOSManagedSettingsUI{
const base::Feature kSafetyCheckIOS{"SafetyCheckIOS", const base::Feature kSafetyCheckIOS{"SafetyCheckIOS",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kIllustratedEmptyStates{"IllustratedEmptyStates",
base::FEATURE_DISABLED_BY_DEFAULT};
...@@ -63,4 +63,7 @@ extern const base::Feature kEnableIOSManagedSettingsUI; ...@@ -63,4 +63,7 @@ extern const base::Feature kEnableIOSManagedSettingsUI;
// Enables the safety check in settings on iOS. // Enables the safety check in settings on iOS.
extern const base::Feature kSafetyCheckIOS; extern const base::Feature kSafetyCheckIOS;
// Feature flag to enable new illustrations and UI on empty states.
extern const base::Feature kIllustratedEmptyStates;
#endif // IOS_CHROME_BROWSER_UI_UI_FEATURE_FLAGS_H_ #endif // IOS_CHROME_BROWSER_UI_UI_FEATURE_FLAGS_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment