Commit 4264c4b3 authored by evliu's avatar evliu Committed by Commit Bot

Disable CFI-icall for the SodaClient

This CL disables the CFI-icall checks for the SodaClient. The function pointers used by the SodaClient are dynamically resolved through the use of dlsym().

Bug: 1152586
Change-Id: I23fab868416b3b91c5dc0a7453480dddf1fa92c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559223
Commit-Queue: Evan Liu <evliu@google.com>
Reviewed-by: default avatarThomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830814}
parent 81803d4c
......@@ -18,6 +18,7 @@ SodaClient::SodaClient(base::FilePath library_path)
sample_rate_(0),
channel_count_(0) {}
NO_SANITIZE("cfi-icall")
SodaClient::~SodaClient() {
DCHECK(soda_async_handle_);
DCHECK(delete_soda_func_);
......@@ -25,6 +26,7 @@ SodaClient::~SodaClient() {
delete_soda_func_(soda_async_handle_);
}
NO_SANITIZE("cfi-icall")
void SodaClient::AddAudio(const char* audio_buffer, int audio_buffer_size) {
DCHECK(soda_async_handle_);
DCHECK(add_audio_func_);
......@@ -35,6 +37,7 @@ bool SodaClient::DidAudioPropertyChange(int sample_rate, int channel_count) {
return sample_rate != sample_rate_ || channel_count != channel_count_;
}
NO_SANITIZE("cfi-icall")
void SodaClient::Reset(const SodaConfig config) {
DCHECK(soda_async_handle_);
DCHECK(create_soda_func_);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment