Commit 42706b86 authored by Boris Sazonov's avatar Boris Sazonov Committed by Commit Bot

[Signin][Android] Don't call updateAccountRenameData from AccountsChangedReceiver

The call to SigninHelper.updateAccountRenameData() in
AccountsChangedReceiver is redundant, as SigninHelper would call
updateAccountRenameData in validateAccountsInternal anyway.

Bug: 1074306
Change-Id: Ib02d364ee06364582816b0896e3ec96d4c3295c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164826Reviewed-by: default avatarAlice Wang <aliceywang@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762817}
parent e5f935fc
......@@ -10,7 +10,6 @@ import android.content.Context;
import android.content.Intent;
import org.chromium.base.ApplicationStatus;
import org.chromium.base.task.AsyncTask;
import org.chromium.base.task.PostTask;
import org.chromium.chrome.browser.init.BrowserParts;
import org.chromium.chrome.browser.init.ChromeBrowserInitializer;
......@@ -32,22 +31,6 @@ public class AccountsChangedReceiver extends BroadcastReceiver {
public void onReceive(Context context, final Intent intent) {
if (!AccountManager.LOGIN_ACCOUNTS_CHANGED_ACTION.equals(intent.getAction())) return;
AsyncTask<Void> task = new AsyncTask<Void>() {
@Override
protected Void doInBackground() {
SigninHelper.updateAccountRenameData();
return null;
}
@Override
protected void onPostExecute(Void result) {
continueHandleAccountChangeIfNeeded();
}
};
task.executeOnExecutor(AsyncTask.SERIAL_EXECUTOR);
}
private void continueHandleAccountChangeIfNeeded() {
boolean isChromeVisible = ApplicationStatus.hasVisibleActivities();
if (isChromeVisible) {
startBrowserIfNeededAndValidateAccounts();
......
......@@ -236,7 +236,7 @@ public class SigninHelper {
return name == null ? ChromeSigninController.get().getSignedInAccountName() : name;
}
public static void updateAccountRenameData() {
private static void updateAccountRenameData() {
updateAccountRenameData(new SystemAccountChangeEventChecker());
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment