Commit 42bf3079 authored by aurimas's avatar aurimas Committed by Commit bot

Move upstreamed calls to FirstRunActivity.

BUG=428842

Review URL: https://codereview.chromium.org/1015833005

Cr-Commit-Position: refs/heads/master@{#321893}
parent fab70f55
...@@ -11,9 +11,11 @@ import android.os.Bundle; ...@@ -11,9 +11,11 @@ import android.os.Bundle;
import android.support.v4.view.ViewPager; import android.support.v4.view.ViewPager;
import android.support.v7.app.ActionBarActivity; import android.support.v7.app.ActionBarActivity;
import android.text.TextUtils; import android.text.TextUtils;
import android.util.Log;
import org.chromium.base.ApplicationStatus; import org.chromium.base.ApplicationStatus;
import org.chromium.base.VisibleForTesting; import org.chromium.base.VisibleForTesting;
import org.chromium.base.library_loader.ProcessInitException;
import org.chromium.base.metrics.RecordHistogram; import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromiumApplication; import org.chromium.chrome.browser.ChromiumApplication;
...@@ -136,15 +138,12 @@ public class FirstRunActivity extends ActionBarActivity implements FirstRunPageD ...@@ -136,15 +138,12 @@ public class FirstRunActivity extends ActionBarActivity implements FirstRunPageD
mPager = new ViewPager(this); mPager = new ViewPager(this);
mPager.setId(R.id.fre_pager); mPager.setId(R.id.fre_pager);
setContentView(mPager); setContentView(mPager);
android.util.Log.i("FirstRunActivity", "onCreate: after setContentView");
mProfileDataCache = new ProfileDataCache(FirstRunActivity.this, null); mProfileDataCache = new ProfileDataCache(FirstRunActivity.this, null);
mProfileDataCache.setProfile(Profile.getLastUsedProfile()); mProfileDataCache.setProfile(Profile.getLastUsedProfile());
new FirstRunFlowSequencer(this, mFreProperties) { new FirstRunFlowSequencer(this, mFreProperties) {
@Override @Override
public void onFlowIsKnown(Activity activity, Bundle freProperties) { public void onFlowIsKnown(Activity activity, Bundle freProperties) {
android.util.Log.i("FirstRunActivity", "in onFlowIsKnown");
if (freProperties == null) { if (freProperties == null) {
completeFirstRunExperience(); completeFirstRunExperience();
return; return;
...@@ -174,10 +173,8 @@ public class FirstRunActivity extends ActionBarActivity implements FirstRunPageD ...@@ -174,10 +173,8 @@ public class FirstRunActivity extends ActionBarActivity implements FirstRunPageD
mPager.setAdapter(mPagerAdapter); mPager.setAdapter(mPagerAdapter);
skipPagesIfNecessary(); skipPagesIfNecessary();
android.util.Log.i("FirstRunActivity", "before return from onFlowIsKnown");
} }
}.start(); }.start();
android.util.Log.i("FirstRunActivity", "onCreate: after starting the sequencer");
} }
@Override @Override
...@@ -402,8 +399,21 @@ public class FirstRunActivity extends ActionBarActivity implements FirstRunPageD ...@@ -402,8 +399,21 @@ public class FirstRunActivity extends ActionBarActivity implements FirstRunPageD
} }
} }
protected void initializeBrowserProcess() { private void initializeBrowserProcess() {
// TODO(aurimas): implement this once browser process initialization is upstreamed. // The Chrome browser process must be started here because this Activity
// may be started explicitly for tests cases, from Android notifications or
// when the application is restoring a FRE fragment after Chrome being killed.
// This should happen before super.onCreate() because it might recreate a fragment,
// and a fragment might depend on the native library.
try {
((ChromiumApplication) getApplication())
.startBrowserProcessesAndLoadLibrariesSync(this, true);
mNativeSideIsInitialized = true;
} catch (ProcessInitException e) {
Log.e(TAG, "Unable to load native library.", e);
abortFirstRunExperience();
return;
}
} }
/** /**
...@@ -426,10 +436,6 @@ public class FirstRunActivity extends ActionBarActivity implements FirstRunPageD ...@@ -426,10 +436,6 @@ public class FirstRunActivity extends ActionBarActivity implements FirstRunPageD
// TODO(aurimas): implement this once EmbededContentViewActivity is upstreamed. // TODO(aurimas): implement this once EmbededContentViewActivity is upstreamed.
} }
public void showSignInNotification() {
// TODO(aurimas): implement this once GoogleServicesManager is upstreamed.
}
@Override @Override
public void openDocumentModeSettings() { public void openDocumentModeSettings() {
// TODO(aurimas): implement opening settings once DocumentModeSettings is upstreamed. // TODO(aurimas): implement opening settings once DocumentModeSettings is upstreamed.
......
...@@ -25,7 +25,6 @@ import org.chromium.base.ObserverList; ...@@ -25,7 +25,6 @@ import org.chromium.base.ObserverList;
import org.chromium.base.ThreadUtils; import org.chromium.base.ThreadUtils;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.child_accounts.ChildAccountService; import org.chromium.chrome.browser.child_accounts.ChildAccountService;
import org.chromium.chrome.browser.firstrun.FirstRunActivity;
import org.chromium.chrome.browser.invalidation.InvalidationController; import org.chromium.chrome.browser.invalidation.InvalidationController;
import org.chromium.chrome.browser.notifications.GoogleServicesNotificationController; import org.chromium.chrome.browser.notifications.GoogleServicesNotificationController;
import org.chromium.chrome.browser.sync.ProfileSyncService; import org.chromium.chrome.browser.sync.ProfileSyncService;
...@@ -532,7 +531,8 @@ public class SigninManager { ...@@ -532,7 +531,8 @@ public class SigninManager {
// popup, since the user has not seen the welcome screen where there is easy access // popup, since the user has not seen the welcome screen where there is easy access
// to turn off sync. // to turn off sync.
if (showSignInNotification) { if (showSignInNotification) {
((FirstRunActivity) activity).showSignInNotification(); SigninManager.get(activity).getSigninNotificationController()
.showSyncSignInNotification();
} }
} }
@Override @Override
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment