Commit 42eb495a authored by Mounir Lamouri's avatar Mounir Lamouri Committed by Commit Bot

Flash Embed Rewrite: re-enable tests that were disabled on Mac/Windows.

Looking at the stack from the tests, it's unclear how it was related to
the code it's testing. Re-enabling the tests may help figure out if it
was a temporary issue.

Bug: 879644
Change-Id: I2ea2d95e7f24f71f86e2c147017bb7d01a563323
Reviewed-on: https://chromium-review.googlesource.com/c/1382477
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619408}
parent 72e99932
......@@ -6,7 +6,6 @@
#include "base/metrics/histogram_samples.h"
#include "base/test/metrics/histogram_tester.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
......@@ -186,16 +185,7 @@ TEST_F(FlashEmbedRewriteTest, YouTubeRewriteEmbedSuccess) {
EXPECT_EQ(total_count, samples->TotalCount());
}
// Crashes on Mac/Win only. http://crbug.com/879644
#if defined(OS_WIN) || defined(OS_MACOSX)
#define MAYBE_YouTubeRewriteEmbedSuccessRewrite \
DISABLED_YouTubeRewriteEmbedSuccessRewrite
#else
#define MAYBE_YouTubeRewriteEmbedSuccessRewrite \
YouTubeRewriteEmbedSuccessRewrite
#endif
TEST_F(FlashEmbedRewriteTest, MAYBE_YouTubeRewriteEmbedSuccessRewrite) {
TEST_F(FlashEmbedRewriteTest, YouTubeRewriteEmbedSuccessRewrite) {
std::unique_ptr<base::HistogramSamples> samples = GetHistogramSamples();
auto total_count = 0;
EXPECT_EQ(total_count, samples->TotalCount());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment