Commit 42f3f9c2 authored by Yann Dago's avatar Yann Dago Committed by Commit Bot

Use milestone as version number for appconfig.xml

Bug: 1128264
Change-Id: I841de5c4aa05b1010b276c937f39f8337d6856db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560994
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: default avatarJulian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831106}
parent 5f078cd7
...@@ -122,7 +122,8 @@ class IOSAppConfigWriter(xml_formatted_writer.XMLFormattedWriter): ...@@ -122,7 +122,8 @@ class IOSAppConfigWriter(xml_formatted_writer.XMLFormattedWriter):
'xsi:noNamespaceSchemaLocation'] = schema_location 'xsi:noNamespaceSchemaLocation'] = schema_location
version = self.AddElement(self._app_config, 'version', {}) version = self.AddElement(self._app_config, 'version', {})
self.AddText(version, self.config['version']) milestone = self.config['version'].split(".", 1)[0]
self.AddText(version, milestone)
bundle_id = self.AddElement(self._app_config, 'bundleId', {}) bundle_id = self.AddElement(self._app_config, 'bundleId', {})
self.AddText(bundle_id, self.config['bundle_id']) self.AddText(bundle_id, self.config['bundle_id'])
......
...@@ -65,7 +65,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon): ...@@ -65,7 +65,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon):
<language value="en-US">string description</language> <language value="en-US">string description</language>
</description> </description>
</field>''' </field>'''
expected = self._GetExpectedOutput('83.0.4089.0', expected_configuration, expected = self._GetExpectedOutput('83', expected_configuration,
expected_presentation) expected_presentation)
output = self.GetOutput(policy_json, { output = self.GetOutput(policy_json, {
'_google_chrome': '1', '_google_chrome': '1',
...@@ -93,7 +93,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon): ...@@ -93,7 +93,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon):
<language value="en-US">int description</language> <language value="en-US">int description</language>
</description> </description>
</field>''' </field>'''
expected = self._GetExpectedOutput('83.0.4089.0', expected_configuration, expected = self._GetExpectedOutput('83', expected_configuration,
expected_presentation) expected_presentation)
output = self.GetOutput(policy_json, { output = self.GetOutput(policy_json, {
'_google_chrome': '1', '_google_chrome': '1',
...@@ -151,7 +151,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon): ...@@ -151,7 +151,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon):
</option> </option>
</options> </options>
</field>''' </field>'''
expected = self._GetExpectedOutput('83.0.4089.0', expected_configuration, expected = self._GetExpectedOutput('83', expected_configuration,
expected_presentation) expected_presentation)
output = self.GetOutput(policy_json, { output = self.GetOutput(policy_json, {
'_google_chrome': '1', '_google_chrome': '1',
...@@ -209,7 +209,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon): ...@@ -209,7 +209,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon):
</option> </option>
</options> </options>
</field>''' </field>'''
expected = self._GetExpectedOutput('83.0.4089.0', expected_configuration, expected = self._GetExpectedOutput('83', expected_configuration,
expected_presentation) expected_presentation)
output = self.GetOutput(policy_json, { output = self.GetOutput(policy_json, {
'_google_chrome': '1', '_google_chrome': '1',
...@@ -267,7 +267,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon): ...@@ -267,7 +267,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon):
</option> </option>
</options> </options>
</field>''' </field>'''
expected = self._GetExpectedOutput('83.0.4089.0', expected_configuration, expected = self._GetExpectedOutput('83', expected_configuration,
expected_presentation) expected_presentation)
output = self.GetOutput(policy_json, { output = self.GetOutput(policy_json, {
'_google_chrome': '1', '_google_chrome': '1',
...@@ -295,7 +295,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon): ...@@ -295,7 +295,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon):
<language value="en-US">boolean description</language> <language value="en-US">boolean description</language>
</description> </description>
</field>''' </field>'''
expected = self._GetExpectedOutput('83.0.4089.0', expected_configuration, expected = self._GetExpectedOutput('83', expected_configuration,
expected_presentation) expected_presentation)
output = self.GetOutput(policy_json, { output = self.GetOutput(policy_json, {
'_google_chrome': '1', '_google_chrome': '1',
...@@ -323,7 +323,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon): ...@@ -323,7 +323,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon):
<language value="en-US">list description</language> <language value="en-US">list description</language>
</description> </description>
</field>''' </field>'''
expected = self._GetExpectedOutput('83.0.4089.0', expected_configuration, expected = self._GetExpectedOutput('83', expected_configuration,
expected_presentation) expected_presentation)
output = self.GetOutput(policy_json, { output = self.GetOutput(policy_json, {
'_google_chrome': '1', '_google_chrome': '1',
...@@ -353,7 +353,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon): ...@@ -353,7 +353,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon):
<language value="en-US">dict description</language> <language value="en-US">dict description</language>
</description> </description>
</field>''' </field>'''
expected = self._GetExpectedOutput('83.0.4089.0', expected_configuration, expected = self._GetExpectedOutput('83', expected_configuration,
expected_presentation) expected_presentation)
output = self.GetOutput(policy_json, { output = self.GetOutput(policy_json, {
'_google_chrome': '1', '_google_chrome': '1',
...@@ -381,7 +381,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon): ...@@ -381,7 +381,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon):
<language value="en-US">string description</language> <language value="en-US">string description</language>
</description> </description>
</field>''' </field>'''
expected = self._GetExpectedOutput('83.0.4089.0', expected_configuration, expected = self._GetExpectedOutput('83', expected_configuration,
expected_presentation) expected_presentation)
output = self.GetOutput(policy_json, { output = self.GetOutput(policy_json, {
'_google_chrome': '1', '_google_chrome': '1',
...@@ -409,7 +409,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon): ...@@ -409,7 +409,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon):
<language value="en-US">string description</language> <language value="en-US">string description</language>
</description> </description>
</field>''' </field>'''
expected = self._GetExpectedOutput('83.0.4089.0', expected_configuration, expected = self._GetExpectedOutput('83', expected_configuration,
expected_presentation) expected_presentation)
output = self.GetOutput(policy_json, { output = self.GetOutput(policy_json, {
'_google_chrome': '1', '_google_chrome': '1',
...@@ -448,7 +448,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon): ...@@ -448,7 +448,7 @@ class IOSAppConfigWriterUnitTests(writer_unittest_common.WriterUnittestCommon):
</description> </description>
</field> </field>
</fieldGroup>''' </fieldGroup>'''
expected = self._GetExpectedOutput('83.0.4089.0', expected_configuration, expected = self._GetExpectedOutput('83', expected_configuration,
expected_presentation) expected_presentation)
output = self.GetOutput(policy_json, { output = self.GetOutput(policy_json, {
'_google_chrome': '1', '_google_chrome': '1',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment