Commit 4314861f authored by Nick Diego Yamane's avatar Nick Diego Yamane Committed by Commit Bot

exo: extended-drag: Switch to const refs in delegate functions

R=oshima@chromium.org

Bug: 1099418
Change-Id: Ib3753a2dbc80995b69e4da6b0ef1221934f99310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511717
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823331}
parent 7cf1750e
...@@ -42,8 +42,8 @@ class ExtendedDragSource : public DataSourceObserver, ...@@ -42,8 +42,8 @@ class ExtendedDragSource : public DataSourceObserver,
public: public:
virtual bool ShouldAllowDropAnywhere() const = 0; virtual bool ShouldAllowDropAnywhere() const = 0;
virtual bool ShouldLockCursor() const = 0; virtual bool ShouldLockCursor() const = 0;
virtual void OnSwallowed(std::string mime_type) = 0; virtual void OnSwallowed(const std::string& mime_type) = 0;
virtual void OnUnswallowed(std::string mime_type, virtual void OnUnswallowed(const std::string& mime_type,
const gfx::Vector2d& offset) = 0; const gfx::Vector2d& offset) = 0;
virtual void OnDataSourceDestroying() = 0; virtual void OnDataSourceDestroying() = 0;
......
...@@ -77,12 +77,12 @@ class TestExtendedDragSourceDelegate : public ExtendedDragSource::Delegate { ...@@ -77,12 +77,12 @@ class TestExtendedDragSourceDelegate : public ExtendedDragSource::Delegate {
bool ShouldLockCursor() const override { return lock_cursor_; } bool ShouldLockCursor() const override { return lock_cursor_; }
void OnSwallowed(std::string mime_type) override { void OnSwallowed(const std::string& mime_type) override {
ASSERT_FALSE(swallowed_); ASSERT_FALSE(swallowed_);
swallowed_ = true; swallowed_ = true;
} }
void OnUnswallowed(std::string mime_type, void OnUnswallowed(const std::string& mime_type,
const gfx::Vector2d& offset) override { const gfx::Vector2d& offset) override {
ASSERT_TRUE(swallowed_); ASSERT_TRUE(swallowed_);
swallowed_ = false; swallowed_ = false;
......
...@@ -48,12 +48,12 @@ class ZcrExtendedDragSourceDelegate : public ExtendedDragSource::Delegate { ...@@ -48,12 +48,12 @@ class ZcrExtendedDragSourceDelegate : public ExtendedDragSource::Delegate {
return settings_ & ZCR_EXTENDED_DRAG_V1_OPTIONS_LOCK_CURSOR; return settings_ & ZCR_EXTENDED_DRAG_V1_OPTIONS_LOCK_CURSOR;
} }
void OnSwallowed(std::string mime_type) override { void OnSwallowed(const std::string& mime_type) override {
zcr_extended_drag_source_v1_send_swallow(resource_, mime_type.c_str()); zcr_extended_drag_source_v1_send_swallow(resource_, mime_type.c_str());
wl_client_flush(wl_resource_get_client(resource_)); wl_client_flush(wl_resource_get_client(resource_));
} }
void OnUnswallowed(std::string mime_type, void OnUnswallowed(const std::string& mime_type,
const gfx::Vector2d& offset) override { const gfx::Vector2d& offset) override {
zcr_extended_drag_source_v1_send_unswallow(resource_, mime_type.c_str(), zcr_extended_drag_source_v1_send_unswallow(resource_, mime_type.c_str(),
offset.x(), offset.y()); offset.x(), offset.y());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment