Skip to content

GitLab

T
tangled
Commit 431f30d7 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot
Browse files
Options

Fix flakiness of date-appearance-basic.html and datetimelocal-appearance-basic.html 

These tests call focus() against elements with 'autofocus'.
If autofocus queue was flushed before finishing a test, it showed a
console message.
We don't need to use 'autofocus' attribute in the tests.

Bug: 1010025
Change-Id: Id4836be9b8f1968f33bfc8eefc7edb03edf25a82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833367Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702296}
parent 2fd94f44
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 5 deletions
third_party/blink/web_tests/TestExpectations
View file @ 431f30d7
...@@ -6173,7 +6173,6 @@ crbug.com/1003715 [ Win10 ] http/tests/notifications/serviceworker-notification- ...@@ -6173,7 +6173,6 @@ crbug.com/1003715 [ Win10 ] http/tests/notifications/serviceworker-notification-
# Sheriff 2019-10-01 # Sheriff 2019-10-01
crbug.com/1010013 [ Win10 ] virtual/threaded/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js [ Failure ] crbug.com/1010013 [ Win10 ] virtual/threaded/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js [ Failure ]
crbug.com/1010025 [ Mac ] fast/forms/date/date-appearance-basic.html [ Failure ]
crbug.com/1010032 [ Win7 ] fast/text/fallback-traits-fixup.html [ Failure ] crbug.com/1010032 [ Win7 ] fast/text/fallback-traits-fixup.html [ Failure ]
crbug.com/1010032 [ Win7 ] fast/text/international/bold-bengali.html [ Failure ] crbug.com/1010032 [ Win7 ] fast/text/international/bold-bengali.html [ Failure ]
crbug.com/1010032 [ Win7 ] fast/text/selection/khmer-selection.html [ Failure ] crbug.com/1010032 [ Win7 ] fast/text/selection/khmer-selection.html [ Failure ]
......
third_party/blink/web_tests/fast/forms/date/date-appearance-basic.html
View file @ 431f30d7
<html> <html>
<body> <body>
<ul> <ul>
<li>Basic <input type="date" autofocus> <input type="date" value="2012-10-05"></li> <li>Basic <input type="date"> <input type="date" value="2012-10-05"></li>
<li>:hover <input type="date" value="2013-12-11" id="hovered"></li> <li>:hover <input type="date" value="2013-12-11" id="hovered"></li>
<li>Disabled <input type="date" disabled> <input type="date" value="2012-10-05" disabled></li> <li>Disabled <input type="date" disabled> <input type="date" value="2012-10-05" disabled></li>
<li>Read-only <input type="date" readonly> <input type="date" value="2012-10-05" readonly></li> <li>Read-only <input type="date" readonly> <input type="date" value="2012-10-05" readonly></li>
...@@ -30,7 +30,7 @@ ...@@ -30,7 +30,7 @@
var input = document.getElementById('hovered'); var input = document.getElementById('hovered');
if (window.eventSender) if (window.eventSender)
eventSender.mouseMoveTo(input.offsetLeft + input.offsetWidth / 2, input.offsetTop + input.offsetHeight / 2); eventSender.mouseMoveTo(input.offsetLeft + input.offsetWidth / 2, input.offsetTop + input.offsetHeight / 2);
document.querySelector('input[autofocus]').focus(); document.querySelector('input').focus();
</script> </script>
</body> </body>
</html> </html>
third_party/blink/web_tests/fast/forms/datetimelocal/datetimelocal-appearance-basic.html
View file @ 431f30d7
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
<html> <html>
<body> <body>
<ul> <ul>
<li>step=none <input autofocus type="datetime-local"> <input type="datetime-local" value="9876-05-04T12:34"></li> <li>step=none <input type="datetime-local"> <input type="datetime-local" value="9876-05-04T12:34"></li>
<li>step=1 <input type="datetime-local" step="1"> <input step="1" type="datetime-local" value="9876-05-04T12:34:56"></li> <li>step=1 <input type="datetime-local" step="1"> <input step="1" type="datetime-local" value="9876-05-04T12:34:56"></li>
<li>step=0.001 <input type="datetime-local" step="0.001"> <input step="0.001" type="datetime-local" value="9876-05-04T12:34:56.789"></li> <li>step=0.001 <input type="datetime-local" step="0.001"> <input step="0.001" type="datetime-local" value="9876-05-04T12:34:56.789"></li>
<li>step=3600 <input type="datetime-local" step="3600"> <input step="3600" type="datetime-local" value="9876-05-04T12:00"></li> <li>step=3600 <input type="datetime-local" step="3600"> <input step="3600" type="datetime-local" value="9876-05-04T12:00"></li>
...@@ -24,7 +24,7 @@ ...@@ -24,7 +24,7 @@
<li>padding: <input type="datetime-local" value="1234-05-06T12:34:56" style="padding: 20px"></li> <li>padding: <input type="datetime-local" value="1234-05-06T12:34:56" style="padding: 20px"></li>
</ul> </ul>
<script> <script>
document.querySelector('input[autofocus]').focus(); document.querySelector('input').focus();
</script> </script>
</body> </body>
</html> </html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment