Commit 432d2962 authored by Nico Weber's avatar Nico Weber

Fix LNK1210 when linking blink_core.dll in gn builds.

This matches the 'LinkIncremental': '1' for webcore_shared
in core.gyp ('1' means 'off' for LinkIncremental).

Patch dictated by scottmg over a noisy channel; typing and
denoising by me.

BUG=587530
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1709783002 .

Cr-Commit-Position: refs/heads/master@{#376000}
parent 6b851bfe
...@@ -173,6 +173,13 @@ component("core") { ...@@ -173,6 +173,13 @@ component("core") {
":svg", ":svg",
] ]
if (is_win && is_debug) {
# Incremental linking doesn't work on this target in debug mode, even
# with symbol_level=1.
configs -= [ "//build/config/win:default_incremental_linking" ]
configs += [ "//build/config/win:no_incremental_linking" ]
}
public_configs = [ public_configs = [
":core_include_dirs", ":core_include_dirs",
":link_core_modules_separately", ":link_core_modules_separately",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment