Commit 4358ab2b authored by chcunningham's avatar chcunningham Committed by Commit bot

Disable flakey Mp3FastSeekIntegrationTest.FastSeekAccuracy_MP3 test on MAC OSX.

TODO: root cause and re-enable.

BUG=571898

Review URL: https://codereview.chromium.org/1644183002

Cr-Commit-Position: refs/heads/master@{#372248}
parent ff871463
...@@ -1359,22 +1359,34 @@ TEST_P(Mp3FastSeekIntegrationTest, FastSeekAccuracy_MP3) { ...@@ -1359,22 +1359,34 @@ TEST_P(Mp3FastSeekIntegrationTest, FastSeekAccuracy_MP3) {
EXPECT_HASH_EQ(config.hash, GetAudioHash()); EXPECT_HASH_EQ(config.hash, GetAudioHash());
} }
// TODO(CHCUNNINGHAM): Re-enable for OSX once 1% flakiness is root caused.
// See http://crbug.com/571898
#if !defined(OS_MACOSX)
// CBR seeks should always be fast and accurate. // CBR seeks should always be fast and accurate.
INSTANTIATE_TEST_CASE_P( INSTANTIATE_TEST_CASE_P(
CBRSeeks, CBRSeek_HasTOC,
Mp3FastSeekIntegrationTest, Mp3FastSeekIntegrationTest,
::testing::Values(Mp3FastSeekParams("bear-audio-10s-CBR-has-TOC.mp3", ::testing::Values(Mp3FastSeekParams("bear-audio-10s-CBR-has-TOC.mp3",
"-0.71,0.36,2.96,2.68,2.10,-1.08,"), "-0.71,0.36,2.96,2.68,2.10,-1.08,")));
Mp3FastSeekParams("bear-audio-10s-CBR-no-TOC.mp3", #endif
INSTANTIATE_TEST_CASE_P(
CBRSeeks_NoTOC,
Mp3FastSeekIntegrationTest,
::testing::Values(Mp3FastSeekParams("bear-audio-10s-CBR-no-TOC.mp3",
"0.95,0.56,1.34,0.47,1.77,0.84,"))); "0.95,0.56,1.34,0.47,1.77,0.84,")));
// VBR seeks can be fast *OR* accurate, but not both. We chose fast. // VBR seeks can be fast *OR* accurate, but not both. We chose fast.
INSTANTIATE_TEST_CASE_P( INSTANTIATE_TEST_CASE_P(
VBRSeeks, VBRSeeks_HasTOC,
Mp3FastSeekIntegrationTest, Mp3FastSeekIntegrationTest,
::testing::Values(Mp3FastSeekParams("bear-audio-10s-VBR-has-TOC.mp3", ::testing::Values(Mp3FastSeekParams("bear-audio-10s-VBR-has-TOC.mp3",
"-0.15,-0.83,0.54,1.00,1.94,0.93,"), "-0.15,-0.83,0.54,1.00,1.94,0.93,")));
Mp3FastSeekParams("bear-audio-10s-VBR-no-TOC.mp3",
INSTANTIATE_TEST_CASE_P(
VBRSeeks_NoTOC,
Mp3FastSeekIntegrationTest,
::testing::Values(Mp3FastSeekParams("bear-audio-10s-VBR-no-TOC.mp3",
"-0.22,0.80,1.19,0.73,-0.31,-1.12,"))); "-0.22,0.80,1.19,0.73,-0.31,-1.12,")));
#endif // !defined(DISABLE_CLOCKLESS_TESTS) #endif // !defined(DISABLE_CLOCKLESS_TESTS)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment