Commit 4358ed72 authored by Tim van der Lippe's avatar Tim van der Lippe Committed by Commit Bot

Use isRequestFilteredOut for network requests

This requires
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2422960
to land in Chromium first.

R=szuend@chromium.org

Bug: 1011811
Change-Id: Ib2488a082456ad1cb4a0f7e77ec4a14a5a410ef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423846Reviewed-by: default avatarSimon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809372}
parent 0d292152
...@@ -50,7 +50,7 @@ ...@@ -50,7 +50,7 @@
UI.panels.network._networkLogView._filterChanged(/* event */ null); UI.panels.network._networkLogView._filterChanged(/* event */ null);
for (const node of UI.panels.network._networkLogView.flatNodesList()) { for (const node of UI.panels.network._networkLogView.flatNodesList()) {
if (node[Network.NetworkLogView._isFilteredOutSymbol]) if (Network.NetworkLogView.isRequestFilteredOut(node))
continue; continue;
const request = node.requestOrFirstKnownChildRequest(); const request = node.requestOrFirstKnownChildRequest();
......
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
async function isFilteredOut(request) { async function isFilteredOut(request) {
var node = await NetworkTestRunner.waitForNetworkLogViewNodeForRequest(request); var node = await NetworkTestRunner.waitForNetworkLogViewNodeForRequest(request);
return !!node[Network.NetworkLogView._isFilteredOutSymbol]; return Network.NetworkLogView.isRequestFilteredOut(node);
} }
TestRunner.addResult(''); TestRunner.addResult('');
......
...@@ -38,7 +38,7 @@ ...@@ -38,7 +38,7 @@
var nodes = UI.panels.network._networkLogView.flatNodesList(); var nodes = UI.panels.network._networkLogView.flatNodesList();
var foundNodesCount = 0; var foundNodesCount = 0;
for (var i = 0; i < nodes.length; i++) { for (var i = 0; i < nodes.length; i++) {
if (!nodes[i][Network.NetworkLogView._isFilteredOutSymbol]) if (!Network.NetworkLogView.isRequestFilteredOut(nodes[i]))
foundNodesCount++; foundNodesCount++;
} }
......
...@@ -65,7 +65,7 @@ ...@@ -65,7 +65,7 @@
const nodes = UI.panels.network._networkLogView.flatNodesList(); const nodes = UI.panels.network._networkLogView.flatNodesList();
let foundNodesCount = 0; let foundNodesCount = 0;
for (let i = 0; i < nodes.length; i++) { for (let i = 0; i < nodes.length; i++) {
if (!nodes[i][Network.NetworkLogView._isFilteredOutSymbol]) if (!Network.NetworkLogView.isRequestFilteredOut(nodes[i]))
foundNodesCount++; foundNodesCount++;
} }
......
...@@ -21,7 +21,8 @@ ...@@ -21,7 +21,8 @@
TestRunner.networkManager._dispatcher._startNetworkRequest(request); TestRunner.networkManager._dispatcher._startNetworkRequest(request);
target._refresh(); target._refresh();
var isFilteredOut = !!target.nodeForRequest(request)[Network.NetworkLogView._isFilteredOutSymbol]; var isFilteredOut = Network.NetworkLogView.isRequestFilteredOut(
target.nodeForRequest(request));
TestRunner.addResult(''); TestRunner.addResult('');
TestRunner.addResult( TestRunner.addResult(
'Appended request [' + request.requestId() + '] of type \'' + request.resourceType().name() + 'Appended request [' + request.requestId() + '] of type \'' + request.resourceType().name() +
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment