Commit 435c96f7 authored by Mila Green's avatar Mila Green Committed by Chromium LUCI CQ

Updater: Add NSError handling for NetworkFetcher file download.

Bug: 1157996
Change-Id: If0c0b401445cb174db2ce0fbd8cbbc5af3a12867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590651Reviewed-by: default avatarSorin Jianu <sorin@chromium.org>
Commit-Queue: Mila Green <milagreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836858}
parent 85755e5b
......@@ -248,16 +248,24 @@ using DownloadToFileCompleteCallback =
didCompleteWithError:(NSError*)error {
[super URLSession:session task:task didCompleteWithError:error];
// TODO(crbug.com/1157996): Add handling for NSError.
NSInteger result;
NSHTTPURLResponse* response = (NSHTTPURLResponse*)task.response;
NSInteger result = response.statusCode == 200 ? 0 : response.statusCode;
if (error) {
result = [error code];
DLOG(ERROR) << "NSError code: " << result << ". NSErrorDomain: "
<< base::SysNSStringToUTF8([error domain])
<< ". NSError description: "
<< base::SysNSStringToUTF8([error description]);
} else {
NSHTTPURLResponse* response = (NSHTTPURLResponse*)task.response;
result = response.statusCode == 200 ? 0 : response.statusCode;
if (!_moveTempFileSuccessful) {
DLOG(ERROR) << "File not moved. Original status code: "
<< response.statusCode;
result = updater::kErrorFailedToMoveDownloadedFile;
if (!result && !_moveTempFileSuccessful) {
DLOG(ERROR) << "File downloaded successfully. Moving temp file failed.";
result = updater::kErrorFailedToMoveDownloadedFile;
}
}
_callbackRunner->PostTask(
FROM_HERE, base::BindOnce(std::move(_downloadToFileCompleteCallback),
result, [task countOfBytesReceived]));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment