[Settings Networking] Fix issue with toggle affecting all networks.

This CL fixes issue with Auto connect toggle button toggling for
other networks. This was caused because the updates to fake pref
objects that control this toggle is not propagated down to the
children, thus the toggle maintains same value from last network
detail page. Fixed this by updating the entire pref object instead
of just the value sub-property.

Bug: 957224
Change-Id: Ic95c2b0ed9f77d9547114fe01acfcc18023c38fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622415
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662836}

chrome/browser/resources/settings/internet_page/internet_detail_page.html

@@ -183,6 +183,7 @@
           if="[[showAutoConnect_(networkProperties_, globalPolicy,
               managedNetworkAvailable)]]">
         <settings-toggle-button
+            id="autoConnectToggle"
             pref="{{autoConnect_}}"
             label="[[getAutoConnectToggleLabel_(networkProperties_)]]">
         </settings-toggle-button>

chrome/browser/resources/settings/internet_page/internet_detail_page.js

@@ -88,7 +88,7 @@ Polymer({
     globalPolicy: {
       type: Object,
       value: null,
-      observer: 'updateAutoConnectPref_',
+      observer: 'globalPolicyChanged_',
     },
 
     /**
@@ -276,6 +276,12 @@ Polymer({
     });
   },
 
+  /** @param {!chrome.networkingPrivate.GlobalPolicy} globalPolicy */
+  globalPolicyChanged_: function(globalPolicy) {
+    this.updateAutoConnectPref_(
+        !!(this.autoConnect_ && this.autoConnect_.value), globalPolicy);
+  },
+
   /** @private */
   networkPropertiesChanged_: function() {
     if (!this.networkProperties_) {
@@ -283,13 +289,8 @@ Polymer({
     }
 
     // Update autoConnect if it has changed. Default value is false.
-    const autoConnect = CrOnc.getAutoConnect(this.networkProperties_);
-    if (this.autoConnect_ === undefined) {
-      this.updateAutoConnectPref_();
-    }
-    if (autoConnect != this.autoConnect_.value) {
-      this.autoConnect_.value = autoConnect;
-    }
+    this.updateAutoConnectPref_(
+        CrOnc.getAutoConnect(this.networkProperties_), this.globalPolicy);
 
     // Update preferNetwork if it has changed. Default value is false.
     const priority = /** @type {number} */ (
@@ -338,18 +339,36 @@ Polymer({
     this.setNetworkProperties_(onc);
   },
 
-  /** @private */
-  updateAutoConnectPref_: function() {
+  /**
+   * Updates auto-connect pref value.
+   * @param {boolean} value
+   * @param {!chrome.networkingPrivate.GlobalPolicy|undefined} globalPolicy
+   * @private
+   */
+  updateAutoConnectPref_: function(value, globalPolicy) {
+    let enforcement;
+    let controlledBy;
+
+    if (this.isAutoConnectEnforcedByPolicy(
+            this.networkProperties_, globalPolicy)) {
+      enforcement = chrome.settingsPrivate.Enforcement.ENFORCED;
+      controlledBy = chrome.settingsPrivate.ControlledBy.DEVICE_POLICY;
+    }
+
+    if (this.autoConnect_ && this.autoConnect_.value == value &&
+        enforcement == this.autoConnect_.enforcement &&
+        controlledBy == this.autoConnect_.controlledBy) {
+      return;
+    }
+
     const newPrefValue = {
       key: 'fakeAutoConnectPref',
-      value: !!this.autoConnect_ && !!this.autoConnect_.value,
+      value: value,
       type: chrome.settingsPrivate.PrefType.BOOLEAN,
     };
-    if (this.isAutoConnectEnforcedByPolicy(
-            this.networkProperties_, this.globalPolicy)) {
-      newPrefValue.controlledBy =
-          chrome.settingsPrivate.ControlledBy.DEVICE_POLICY;
-      newPrefValue.enforcement = chrome.settingsPrivate.Enforcement.ENFORCED;
+    if (enforcement) {
+      newPrefValue.enforcement = enforcement;
+      newPrefValue.controlledBy = controlledBy;
     }
 
     this.autoConnect_ = newPrefValue;

chrome/test/data/webui/settings/internet_detail_page_tests.js

@@ -256,5 +256,37 @@ suite('InternetDetailPage', function() {
         assertTrue(connectButton.hasAttribute('disabled'));
       });
     });
+
+    test.only(
+        'Auto Connect toggle updates properly after GUID change', function() {
+          api_.enableNetworkType('WiFi');
+          setNetworksForTest([
+            {
+              GUID: 'wifi1_guid',
+              Name: 'wifi1',
+              Type: 'WiFi',
+              Source: CrOnc.Source.USER,
+              WiFi: {AutoConnect: true}
+            },
+            {
+              GUID: 'wifi2_guid',
+              Name: 'wifi1',
+              Type: 'WiFi',
+              Source: CrOnc.Source.USER,
+              WiFi: {AutoConnect: false}
+            }
+          ]);
+          internetDetailPage.init('wifi1_guid', 'WiFi', 'wifi_user');
+          return flushAsync()
+              .then(() => {
+                assertTrue(internetDetailPage.$$('#autoConnectToggle').checked);
+                internetDetailPage.init('wifi2_guid', 'WiFi', 'wifi_user');
+                return flushAsync();
+              })
+              .then(() => {
+                assertFalse(
+                    internetDetailPage.$$('#autoConnectToggle').checked);
+              });
+        });
   });
 });