Commit 4378a01c authored by Florin Malita's avatar Florin Malita Committed by Commit Bot

Refactor FontResource to avoid SharedBuffer::Data()

Since PackageFormatOf() only needs the first 4 bytes, just copy them to
a local buffer.

BUG=728627

Change-Id: I19e65c95f4737968967fb63196b8ed6d07fa7fae
Reviewed-on: https://chromium-review.googlesource.com/577673Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarHajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488201}
parent a9368540
......@@ -55,10 +55,11 @@ enum FontPackageFormat {
};
static FontPackageFormat PackageFormatOf(SharedBuffer* buffer) {
if (buffer->size() < 4)
static constexpr size_t kMaxHeaderSize = 4;
char data[kMaxHeaderSize];
if (!buffer->GetBytes(data, kMaxHeaderSize))
return kPackageFormatUnknown;
const char* data = buffer->Data();
if (data[0] == 'w' && data[1] == 'O' && data[2] == 'F' && data[3] == 'F')
return kPackageFormatWOFF;
if (data[0] == 'w' && data[1] == 'O' && data[2] == 'F' && data[3] == '2')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment