Commit 4379fc47 authored by Pavel Feldman's avatar Pavel Feldman

DevTools: mark protocol methods used in Puppeteer public (non-experimental).

Change-Id: I9d00ab87636cef3227cf04d7aa05b01b809103e6
TBR: headless test
Reviewed-on: https://chromium-review.googlesource.com/744729Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513316}
parent d34d8303
...@@ -1333,8 +1333,8 @@ class DomTreeExtractionBrowserTest : public HeadlessAsyncDevTooledBrowserTest, ...@@ -1333,8 +1333,8 @@ class DomTreeExtractionBrowserTest : public HeadlessAsyncDevTooledBrowserTest,
if (layout_node->HasInlineTextNodes()) { if (layout_node->HasInlineTextNodes()) {
std::unique_ptr<base::ListValue> inline_text_nodes( std::unique_ptr<base::ListValue> inline_text_nodes(
new base::ListValue()); new base::ListValue());
for (const std::unique_ptr<css::InlineTextBox>& inline_text_box : for (const std::unique_ptr<dom_snapshot::InlineTextBox>&
*layout_node->GetInlineTextNodes()) { inline_text_box : *layout_node->GetInlineTextNodes()) {
size_t index = inline_text_nodes->GetSize(); size_t index = inline_text_nodes->GetSize();
inline_text_nodes->Set(index, inline_text_box->Serialize()); inline_text_nodes->Set(index, inline_text_box->Serialize());
} }
......
...@@ -323,9 +323,9 @@ int InspectorDOMSnapshotAgent::VisitLayoutTreeNode(Node* node, int node_index) { ...@@ -323,9 +323,9 @@ int InspectorDOMSnapshotAgent::VisitLayoutTreeNode(Node* node, int node_index) {
LayoutText* layout_text = ToLayoutText(layout_object); LayoutText* layout_text = ToLayoutText(layout_object);
layout_tree_node->setLayoutText(layout_text->GetText()); layout_tree_node->setLayoutText(layout_text->GetText());
if (layout_text->HasTextBoxes()) { if (layout_text->HasTextBoxes()) {
std::unique_ptr<protocol::Array<protocol::CSS::InlineTextBox>> std::unique_ptr<protocol::Array<protocol::DOMSnapshot::InlineTextBox>>
inline_text_nodes = inline_text_nodes =
protocol::Array<protocol::CSS::InlineTextBox>::create(); protocol::Array<protocol::DOMSnapshot::InlineTextBox>::create();
for (const InlineTextBox* text_box = layout_text->FirstTextBox(); for (const InlineTextBox* text_box = layout_text->FirstTextBox();
text_box; text_box = text_box->NextTextBox()) { text_box; text_box = text_box->NextTextBox()) {
FloatRect local_coords_text_box_rect(text_box->FrameRect()); FloatRect local_coords_text_box_rect(text_box->FrameRect());
...@@ -333,7 +333,7 @@ int InspectorDOMSnapshotAgent::VisitLayoutTreeNode(Node* node, int node_index) { ...@@ -333,7 +333,7 @@ int InspectorDOMSnapshotAgent::VisitLayoutTreeNode(Node* node, int node_index) {
layout_object->LocalToAbsoluteQuad(local_coords_text_box_rect) layout_object->LocalToAbsoluteQuad(local_coords_text_box_rect)
.BoundingBox(); .BoundingBox();
inline_text_nodes->addItem( inline_text_nodes->addItem(
protocol::CSS::InlineTextBox::create() protocol::DOMSnapshot::InlineTextBox::create()
.setStartCharacterIndex(text_box->Start()) .setStartCharacterIndex(text_box->Start())
.setNumCharacters(text_box->Len()) .setNumCharacters(text_box->Len())
.setBoundingBox( .setBoundingBox(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment