Commit 43b756b4 authored by Peng Huang's avatar Peng Huang Committed by Commit Bot

Remove some TODOs which have been addressed.

Bug: None
Change-Id: I40b36e01f42da2dd0e21d5395155073feb356355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955659
Commit-Queue: Peng Huang <penghuang@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: default avatarVasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722507}
parent 3df81bcb
...@@ -231,15 +231,11 @@ class SkiaOutputSurfaceImplOnGpu::ScopedPromiseImageAccess { ...@@ -231,15 +231,11 @@ class SkiaOutputSurfaceImplOnGpu::ScopedPromiseImageAccess {
begin_semaphores_.reserve(image_contexts_.size()); begin_semaphores_.reserve(image_contexts_.size());
// We may need one more space for the swap buffer semaphore. // We may need one more space for the swap buffer semaphore.
end_semaphores_.reserve(image_contexts_.size() + 1); end_semaphores_.reserve(image_contexts_.size() + 1);
// TODO(penghuang): gather begin read access semaphores from shared images.
// https://crbug.com/944194
impl_on_gpu_->BeginAccessImages(image_contexts_, &begin_semaphores_, impl_on_gpu_->BeginAccessImages(image_contexts_, &begin_semaphores_,
&end_semaphores_); &end_semaphores_);
} }
~ScopedPromiseImageAccess() { ~ScopedPromiseImageAccess() {
// TODO(penghuang): end shared image access with meaningful semaphores.
// https://crbug.com/944194
impl_on_gpu_->EndAccessImages(image_contexts_); impl_on_gpu_->EndAccessImages(image_contexts_);
} }
...@@ -324,7 +320,6 @@ scoped_refptr<gpu::SyncPointClientState> CreateSyncPointClientState( ...@@ -324,7 +320,6 @@ scoped_refptr<gpu::SyncPointClientState> CreateSyncPointClientState(
std::unique_ptr<gpu::SharedImageRepresentationFactory> std::unique_ptr<gpu::SharedImageRepresentationFactory>
CreateSharedImageRepresentationFactory(SkiaOutputSurfaceDependency* deps, CreateSharedImageRepresentationFactory(SkiaOutputSurfaceDependency* deps,
gpu::MemoryTracker* memory_tracker) { gpu::MemoryTracker* memory_tracker) {
// TODO(https://crbug.com/899905): Use a real MemoryTracker, not nullptr.
return std::make_unique<gpu::SharedImageRepresentationFactory>( return std::make_unique<gpu::SharedImageRepresentationFactory>(
deps->GetSharedImageManager(), memory_tracker); deps->GetSharedImageManager(), memory_tracker);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment