Commit 43c54600 authored by Stepan Khapugin's avatar Stepan Khapugin Committed by Commit Bot

[iOS] Disable AutofillAddCreditCardTestCase tests on iPads.

Disable tests:
 AutofillAddCreditCardTestCase/testAddButtonOnValidNumber
 AutofillAddCreditCardTestCase/testCancelButtonDismissesScreen
 AutofillAddCreditCardTestCase/testAddButtonOnValidNickname


Bug: 1149306
Change-Id: I64c024251e78df6c35fc5515fe8ec576d1a4f687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537642
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: default avatarJérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827744}
parent 0e1fcaf4
...@@ -146,7 +146,12 @@ id<GREYMatcher> CardNumberIconView(NSString* icon_type) { ...@@ -146,7 +146,12 @@ id<GREYMatcher> CardNumberIconView(NSString* icon_type) {
} }
// Tests that the 'Cancel' button dismisses the screen. // Tests that the 'Cancel' button dismisses the screen.
// TODO(crbug.com/1149306): test flaky on iPads.
- (void)testCancelButtonDismissesScreen { - (void)testCancelButtonDismissesScreen {
if ([ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Fails on iPad.");
}
[[EarlGrey selectElementWithMatcher:chrome_test_util::AddCreditCardView()] [[EarlGrey selectElementWithMatcher:chrome_test_util::AddCreditCardView()]
assertWithMatcher:grey_notNil()]; assertWithMatcher:grey_notNil()];
[[EarlGrey [[EarlGrey
...@@ -220,7 +225,11 @@ id<GREYMatcher> CardNumberIconView(NSString* icon_type) { ...@@ -220,7 +225,11 @@ id<GREYMatcher> CardNumberIconView(NSString* icon_type) {
// Tests when a user tries to add a valid card number, the screen is dismissed // Tests when a user tries to add a valid card number, the screen is dismissed
// and the new card number appears on the Autofill Credit Card 'Payment Methods' // and the new card number appears on the Autofill Credit Card 'Payment Methods'
// screen. // screen.
// TODO(crbug.com/1149306): test flaky on iPads.
- (void)testAddButtonOnValidNumber { - (void)testAddButtonOnValidNumber {
if ([ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Fails on iPad.");
}
[AutofillAppInterface clearCreditCardStore]; [AutofillAppInterface clearCreditCardStore];
[[EarlGrey selectElementWithMatcher:CardNumberTextField()] [[EarlGrey selectElementWithMatcher:CardNumberTextField()]
performAction:grey_typeText(@"4111111111111111")]; performAction:grey_typeText(@"4111111111111111")];
...@@ -247,11 +256,9 @@ id<GREYMatcher> CardNumberIconView(NSString* icon_type) { ...@@ -247,11 +256,9 @@ id<GREYMatcher> CardNumberIconView(NSString* icon_type) {
// Tests when a user add a card with a nickname, the screen is dismissed // Tests when a user add a card with a nickname, the screen is dismissed
// and the new card number appears on the Autofill Credit Card 'Payment Methods' // and the new card number appears on the Autofill Credit Card 'Payment Methods'
// screen with the nickname. // screen with the nickname.
- (void)testAddButtonOnValidNickname { // TODO(crbug.com/1109663): Enable the test on iPhone once the bug is fixed.
if (![ChromeEarlGrey isIPadIdiom]) { // TODO(crbug.com/1149306): test flaky on iPads.
// TODO(crbug.com/1109663): Enable the test on iPhone once the bug is fixed. - (void)DISABLED_testAddButtonOnValidNickname {
EARL_GREY_TEST_DISABLED(@"Disabled for iPhone.");
}
[AutofillAppInterface clearCreditCardStore]; [AutofillAppInterface clearCreditCardStore];
[[EarlGrey selectElementWithMatcher:CardNumberTextField()] [[EarlGrey selectElementWithMatcher:CardNumberTextField()]
performAction:grey_typeText(@"4111111111111111")]; performAction:grey_typeText(@"4111111111111111")];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment