Commit 43ce6cfa authored by yiyix's avatar yiyix Committed by Commit Bot

Remove unused Chrome histograms Renderer4..*

Remove the following metrics:
Renderer4.CompositorThreadImplDrawDelay (99th percentile by size)
Renderer4.LanguageDetection (95th percentile by size)
Renderer4.SoftwareCompositorThreadImplDrawDelay (85th percentile by size)

Bug: 851784
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I99947370afa55bea137f99a317983db11292e33e
Reviewed-on: https://chromium-review.googlesource.com/1112203Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Reviewed-by: default avatarMichael Martis <martis@chromium.org>
Reviewed-by: default avatarFady Samuel <fsamuel@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572287}
parent 3eea4d7f
...@@ -57,18 +57,6 @@ void FrameRateCounter::SaveTimeStamp(base::TimeTicks timestamp, bool software) { ...@@ -57,18 +57,6 @@ void FrameRateCounter::SaveTimeStamp(base::TimeTicks timestamp, bool software) {
base::TimeDelta frame_interval_seconds = base::TimeDelta frame_interval_seconds =
RecentFrameInterval(ring_buffer_.BufferSize() - 1); RecentFrameInterval(ring_buffer_.BufferSize() - 1);
if (has_impl_thread_ && ring_buffer_.CurrentIndex() > 0) {
if (software) {
UMA_HISTOGRAM_CUSTOM_COUNTS(
"Renderer4.SoftwareCompositorThreadImplDrawDelay",
frame_interval_seconds.InMilliseconds(), 1, 120, 60);
} else {
UMA_HISTOGRAM_CUSTOM_COUNTS("Renderer4.CompositorThreadImplDrawDelay",
frame_interval_seconds.InMilliseconds(), 1,
120, 60);
}
}
if (!IsBadFrameInterval(frame_interval_seconds) && if (!IsBadFrameInterval(frame_interval_seconds) &&
frame_interval_seconds.InSecondsF() > kDroppedFrameTime) frame_interval_seconds.InSecondsF() > kDroppedFrameTime)
dropped_frame_count_ += dropped_frame_count_ +=
......
...@@ -18,7 +18,6 @@ namespace translate { ...@@ -18,7 +18,6 @@ namespace translate {
namespace metrics_internal { namespace metrics_internal {
const char kRenderer4LanguageDetection[] = "Renderer4.LanguageDetection";
const char kTranslateContentLanguage[] = "Translate.ContentLanguage"; const char kTranslateContentLanguage[] = "Translate.ContentLanguage";
const char kTranslateHtmlLang[] = "Translate.HtmlLang"; const char kTranslateHtmlLang[] = "Translate.HtmlLang";
const char kTranslateLanguageVerification[] = "Translate.LanguageVerification"; const char kTranslateLanguageVerification[] = "Translate.LanguageVerification";
...@@ -102,11 +101,6 @@ void ReportPageScheme(const std::string& scheme) { ...@@ -102,11 +101,6 @@ void ReportPageScheme(const std::string& scheme) {
SCHEME_MAX); SCHEME_MAX);
} }
void ReportLanguageDetectionTime(base::TimeTicks begin, base::TimeTicks end) {
UMA_HISTOGRAM_MEDIUM_TIMES(metrics_internal::kRenderer4LanguageDetection,
end - begin);
}
void ReportSimilarLanguageMatch(bool match) { void ReportSimilarLanguageMatch(bool match) {
UMA_HISTOGRAM_BOOLEAN(metrics_internal::kTranslateSimilarLanguageMatch, UMA_HISTOGRAM_BOOLEAN(metrics_internal::kTranslateSimilarLanguageMatch,
match); match);
......
...@@ -16,7 +16,6 @@ namespace translate { ...@@ -16,7 +16,6 @@ namespace translate {
namespace metrics_internal { namespace metrics_internal {
// Constant string values to indicate UMA names. // Constant string values to indicate UMA names.
extern const char kRenderer4LanguageDetection[];
extern const char kTranslateContentLanguage[]; extern const char kTranslateContentLanguage[];
extern const char kTranslateHtmlLang[]; extern const char kTranslateHtmlLang[];
extern const char kTranslateLanguageVerification[]; extern const char kTranslateLanguageVerification[];
...@@ -92,9 +91,6 @@ void ReportUserActionDuration(base::TimeTicks begin, base::TimeTicks end); ...@@ -92,9 +91,6 @@ void ReportUserActionDuration(base::TimeTicks begin, base::TimeTicks end);
// Called when a translation is triggered. // Called when a translation is triggered.
void ReportPageScheme(const std::string& scheme); void ReportPageScheme(const std::string& scheme);
// Called when CLD detects page language.
void ReportLanguageDetectionTime(base::TimeTicks begin, base::TimeTicks end);
// Called when CLD agreed on a language which is different, but in the similar // Called when CLD agreed on a language which is different, but in the similar
// language list. // language list.
void ReportSimilarLanguageMatch(bool match); void ReportSimilarLanguageMatch(bool match);
......
...@@ -279,17 +279,6 @@ TEST(TranslateMetricsTest, ReportSimilarLanguageMatch) { ...@@ -279,17 +279,6 @@ TEST(TranslateMetricsTest, ReportSimilarLanguageMatch) {
EXPECT_EQ(1, recorder.GetCount(kFalse)); EXPECT_EQ(1, recorder.GetCount(kFalse));
} }
TEST(TranslateMetricsTest, ReportLanguageDetectionTime) {
MetricsRecorder recorder(
translate::metrics_internal::kRenderer4LanguageDetection);
recorder.CheckTotalCount(0);
TimeTicks begin = TimeTicks::Now();
TimeTicks end = begin + base::TimeDelta::FromMicroseconds(9009);
translate::ReportLanguageDetectionTime(begin, end);
recorder.CheckValueInLogs(9.009);
recorder.CheckTotalCount(1);
}
TEST(TranslateMetricsTest, ReportLanguageDetectionConflict) { TEST(TranslateMetricsTest, ReportLanguageDetectionConflict) {
MetricsRecorder recorder( MetricsRecorder recorder(
translate::metrics_internal::kTranslateLanguageDetectionConflict); translate::metrics_internal::kTranslateLanguageDetectionConflict);
......
...@@ -15,7 +15,6 @@ ...@@ -15,7 +15,6 @@
#include "base/strings/string_split.h" #include "base/strings/string_split.h"
#include "base/strings/string_util.h" #include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "components/translate/core/common/translate_constants.h" #include "components/translate/core/common/translate_constants.h"
#include "components/translate/core/common/translate_metrics.h" #include "components/translate/core/common/translate_metrics.h"
#include "components/translate/core/common/translate_util.h" #include "components/translate/core/common/translate_util.h"
...@@ -152,7 +151,6 @@ std::string DeterminePageLanguage(const std::string& code, ...@@ -152,7 +151,6 @@ std::string DeterminePageLanguage(const std::string& code,
const base::string16& contents, const base::string16& contents,
std::string* cld_language_p, std::string* cld_language_p,
bool* is_cld_reliable_p) { bool* is_cld_reliable_p) {
base::TimeTicks begin_time = base::TimeTicks::Now();
bool is_cld_reliable; bool is_cld_reliable;
// Check if html lang attribute is valid. // Check if html lang attribute is valid.
std::string modified_html_lang; std::string modified_html_lang;
...@@ -172,7 +170,6 @@ std::string DeterminePageLanguage(const std::string& code, ...@@ -172,7 +170,6 @@ std::string DeterminePageLanguage(const std::string& code,
} }
std::string cld_language = DetermineTextLanguage(contents, &is_cld_reliable); std::string cld_language = DetermineTextLanguage(contents, &is_cld_reliable);
translate::ReportLanguageDetectionTime(begin_time, base::TimeTicks::Now());
if (cld_language_p != nullptr) if (cld_language_p != nullptr)
*cld_language_p = cld_language; *cld_language_p = cld_language;
......
...@@ -78785,6 +78785,10 @@ uploading your change for review. ...@@ -78785,6 +78785,10 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="Renderer4.CompositorThreadImplDrawDelay" units="ms"> <histogram name="Renderer4.CompositorThreadImplDrawDelay" units="ms">
<obsolete>
Deprecated in 06/2018, M69. Renderer4.CompositorThreadImplDrawDelay is no
longer needed due to issue 851784.
</obsolete>
<owner>wiltzius@chromium.org</owner> <owner>wiltzius@chromium.org</owner>
<summary> <summary>
Time between frames, as measured on the compositor thread. This is collected Time between frames, as measured on the compositor thread. This is collected
...@@ -79062,6 +79066,10 @@ uploading your change for review. ...@@ -79062,6 +79066,10 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="Renderer4.LanguageDetection" units="ms"> <histogram name="Renderer4.LanguageDetection" units="ms">
<obsolete>
Deprecated in 06/2018, M69. Renderer4.LanguageDetection is no longer needed
due to issue 851784.
</obsolete>
<owner>wiltzius@chromium.org</owner> <owner>wiltzius@chromium.org</owner>
<summary> <summary>
Time to determine the page language. This is done after the page has been Time to determine the page language. This is done after the page has been
...@@ -79247,6 +79255,10 @@ uploading your change for review. ...@@ -79247,6 +79255,10 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="Renderer4.SoftwareCompositorThreadImplDrawDelay" units="ms"> <histogram name="Renderer4.SoftwareCompositorThreadImplDrawDelay" units="ms">
<obsolete>
Deprecated in 06/2018, M69. Renderer4.SoftwareCompositorThreadImplDrawDelay
is no longer needed due to issue 851784.
</obsolete>
<owner>wiltzius@chromium.org</owner> <owner>wiltzius@chromium.org</owner>
<summary> <summary>
Time between frames when the software renderer is being used, as measured on Time between frames when the software renderer is being used, as measured on
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment