Commit 43d61f2b authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Set include_js_tests to false in win/cross builds.

This will hopefully "fix" the following tests in cross builds (by no longer
running them) in interactive_ui_tests:

  ExtensionSettingsUIBrowserTest.ActivityLogInactiveWithoutSwitch
  ExtensionSettingsUIBrowserTest.ListenerRegistration
  ExtensionSettingsUIBrowserTest.ViewSource
  ExtensionsActivityLogTest.TestActivityLogVisible

See comment 6 on the bug.

If this helps, I'll try reverting #702844 which might then no longer be
necessary.

Bug: 1010561
Change-Id: Id31c4ea33493f6917d3a855d49cada56a032e9c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845801
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703693}
parent 6ce97acf
......@@ -42,7 +42,9 @@ if (is_android) {
import("//chrome/android/features/dev_ui/dev_ui_module.gni")
import("//tools/v8_context_snapshot/v8_context_snapshot.gni")
} else {
include_js_tests = !(is_asan || is_msan || is_tsan)
# js_tests don't work in cross builds, https://crbug.com/1010561
include_js_tests =
!(is_asan || is_msan || is_tsan || (is_win && host_os != "win"))
}
# This target exists to reference other test executables to bring these files
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment