Commit 43d9d784 authored by tdresser@chromium.org's avatar tdresser@chromium.org

Pass DefaultDeviceScaleFactor to webkit

DefaultDeviceScaleFactor will be based solely on the screen DPI, as opposed to DeviceScaleFactor,
which incorporates information from the viewport tag.

This is a follow-up to: https://bugs.webkit.org/show_bug.cgi?id=79534

BUG=115231
TEST=None

Review URL: http://codereview.chromium.org/9500015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124411 0039d316-1c4b-4281-b951-d872f2087c98
parent a39dc844
...@@ -649,7 +649,6 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer( ...@@ -649,7 +649,6 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(
switches::kAuditAllHandles, switches::kAuditAllHandles,
switches::kAuditHandles, switches::kAuditHandles,
switches::kChromeFrame, switches::kChromeFrame,
switches::kDefaultDeviceScaleFactor,
switches::kDisable3DAPIs, switches::kDisable3DAPIs,
switches::kDisableAcceleratedCompositing, switches::kDisableAcceleratedCompositing,
switches::kDisableApplicationCache, switches::kDisableApplicationCache,
......
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
#include "base/metrics/histogram.h" #include "base/metrics/histogram.h"
#include "base/metrics/stats_counters.h" #include "base/metrics/stats_counters.h"
#include "base/string16.h" #include "base/string16.h"
#include "base/string_number_conversions.h"
#include "base/string_util.h" #include "base/string_util.h"
#include "base/time.h" #include "base/time.h"
#include "base/utf_string_conversions.h" #include "base/utf_string_conversions.h"
...@@ -460,6 +461,13 @@ WebPreferences TabContents::GetWebkitPrefs(RenderViewHost* rvh, ...@@ -460,6 +461,13 @@ WebPreferences TabContents::GetWebkitPrefs(RenderViewHost* rvh,
prefs.accelerated_2d_canvas_enabled = false; prefs.accelerated_2d_canvas_enabled = false;
} }
int default_device_scale_factor;
base::StringToInt(command_line.GetSwitchValueASCII(
switches::kDefaultDeviceScaleFactor),
&default_device_scale_factor);
prefs.default_device_scale_factor = default_device_scale_factor;
content::GetContentClient()->browser()->OverrideWebkitPrefs(rvh, &prefs); content::GetContentClient()->browser()->OverrideWebkitPrefs(rvh, &prefs);
return prefs; return prefs;
......
...@@ -140,6 +140,7 @@ IPC_STRUCT_TRAITS_BEGIN(WebPreferences) ...@@ -140,6 +140,7 @@ IPC_STRUCT_TRAITS_BEGIN(WebPreferences)
IPC_STRUCT_TRAITS_MEMBER(fantasy_font_family_map) IPC_STRUCT_TRAITS_MEMBER(fantasy_font_family_map)
IPC_STRUCT_TRAITS_MEMBER(default_font_size) IPC_STRUCT_TRAITS_MEMBER(default_font_size)
IPC_STRUCT_TRAITS_MEMBER(default_fixed_font_size) IPC_STRUCT_TRAITS_MEMBER(default_fixed_font_size)
IPC_STRUCT_TRAITS_MEMBER(default_device_scale_factor)
IPC_STRUCT_TRAITS_MEMBER(minimum_font_size) IPC_STRUCT_TRAITS_MEMBER(minimum_font_size)
IPC_STRUCT_TRAITS_MEMBER(minimum_logical_font_size) IPC_STRUCT_TRAITS_MEMBER(minimum_logical_font_size)
IPC_STRUCT_TRAITS_MEMBER(default_encoding) IPC_STRUCT_TRAITS_MEMBER(default_encoding)
......
...@@ -540,9 +540,6 @@ RenderViewImpl::RenderViewImpl( ...@@ -540,9 +540,6 @@ RenderViewImpl::RenderViewImpl(
webview()->enableFixedLayoutMode(enable_fixed_layout); webview()->enableFixedLayoutMode(enable_fixed_layout);
if (enable_fixed_layout) if (enable_fixed_layout)
webview()->settings()->setFixedElementsLayoutRelativeToFrame(true); webview()->settings()->setFixedElementsLayoutRelativeToFrame(true);
base::StringToInt(command_line.GetSwitchValueASCII(
switches::kDefaultDeviceScaleFactor),
&default_device_scale_factor_);
content::GetContentClient()->renderer()->RenderViewCreated(this); content::GetContentClient()->renderer()->RenderViewCreated(this);
} }
...@@ -4417,9 +4414,9 @@ void RenderViewImpl::OnResize(const gfx::Size& new_size, ...@@ -4417,9 +4414,9 @@ void RenderViewImpl::OnResize(const gfx::Size& new_size,
bool is_fullscreen) { bool is_fullscreen) {
if (webview()) { if (webview()) {
// This setting has no effect if fixed layout is not enabled. // This setting has no effect if fixed layout is not enabled.
if (default_device_scale_factor_) if (webkit_preferences_.default_device_scale_factor)
webview()->settings()->setLayoutFallbackWidth( webview()->settings()->setLayoutFallbackWidth(
new_size.width() / default_device_scale_factor_); new_size.width() / webkit_preferences_.default_device_scale_factor);
webview()->hidePopups(); webview()->hidePopups();
if (send_preferred_size_changes_) { if (send_preferred_size_changes_) {
webview()->mainFrame()->setCanHaveScrollbars( webview()->mainFrame()->setCanHaveScrollbars(
......
...@@ -1020,8 +1020,6 @@ class RenderViewImpl : public RenderWidget, ...@@ -1020,8 +1020,6 @@ class RenderViewImpl : public RenderWidget,
// should be drawn. // should be drawn.
gfx::Size disable_scrollbars_size_limit_; gfx::Size disable_scrollbars_size_limit_;
int default_device_scale_factor_;
// Loading state ------------------------------------------------------------- // Loading state -------------------------------------------------------------
// True if the top level frame is currently being loaded. // True if the top level frame is currently being loaded.
......
...@@ -36,6 +36,7 @@ WebPreferences::WebPreferences() ...@@ -36,6 +36,7 @@ WebPreferences::WebPreferences()
default_fixed_font_size(13), default_fixed_font_size(13),
minimum_font_size(0), minimum_font_size(0),
minimum_logical_font_size(6), minimum_logical_font_size(6),
default_device_scale_factor(1),
default_encoding("ISO-8859-1"), default_encoding("ISO-8859-1"),
javascript_enabled(true), javascript_enabled(true),
web_security_enabled(true), web_security_enabled(true),
...@@ -186,6 +187,7 @@ void WebPreferences::Apply(WebView* web_view) const { ...@@ -186,6 +187,7 @@ void WebPreferences::Apply(WebView* web_view) const {
settings->setDefaultFixedFontSize(default_fixed_font_size); settings->setDefaultFixedFontSize(default_fixed_font_size);
settings->setMinimumFontSize(minimum_font_size); settings->setMinimumFontSize(minimum_font_size);
settings->setMinimumLogicalFontSize(minimum_logical_font_size); settings->setMinimumLogicalFontSize(minimum_logical_font_size);
settings->setDefaultDeviceScaleFactor(default_device_scale_factor);
settings->setDefaultTextEncodingName(ASCIIToUTF16(default_encoding)); settings->setDefaultTextEncodingName(ASCIIToUTF16(default_encoding));
settings->setJavaScriptEnabled(javascript_enabled); settings->setJavaScriptEnabled(javascript_enabled);
settings->setWebSecurityEnabled(web_security_enabled); settings->setWebSecurityEnabled(web_security_enabled);
......
...@@ -43,6 +43,7 @@ struct WEBKIT_GLUE_EXPORT WebPreferences { ...@@ -43,6 +43,7 @@ struct WEBKIT_GLUE_EXPORT WebPreferences {
int default_fixed_font_size; int default_fixed_font_size;
int minimum_font_size; int minimum_font_size;
int minimum_logical_font_size; int minimum_logical_font_size;
int default_device_scale_factor;
std::string default_encoding; std::string default_encoding;
bool javascript_enabled; bool javascript_enabled;
bool web_security_enabled; bool web_security_enabled;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment