Commit 43e4ffc6 authored by Michael Giuffrida's avatar Michael Giuffrida Committed by Commit Bot

Remove unused LocaleChanged methods in Views.

Bug: 
Change-Id: I40041b48ffed49826f2b725ab06a2b7b5964282e
Reviewed-on: https://chromium-review.googlesource.com/587353
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491351}
parent e4f503e9
...@@ -123,10 +123,6 @@ void BaseDateTimeView::ChildPreferredSizeChanged(views::View* child) { ...@@ -123,10 +123,6 @@ void BaseDateTimeView::ChildPreferredSizeChanged(views::View* child) {
PreferredSizeChanged(); PreferredSizeChanged();
} }
void BaseDateTimeView::OnLocaleChanged() {
UpdateText();
}
/////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////
DateView::DateView(SystemTrayItem* owner) DateView::DateView(SystemTrayItem* owner)
......
...@@ -52,7 +52,6 @@ class ASH_EXPORT BaseDateTimeView : public ActionableView { ...@@ -52,7 +52,6 @@ class ASH_EXPORT BaseDateTimeView : public ActionableView {
// views::View: // views::View:
void ChildPreferredSizeChanged(views::View* child) override; void ChildPreferredSizeChanged(views::View* child) override;
void OnLocaleChanged() override;
// Invokes UpdateText() when the displayed time should change. // Invokes UpdateText() when the displayed time should change.
base::OneShotTimer timer_; base::OneShotTimer timer_;
......
...@@ -409,9 +409,6 @@ void WebUILoginView::Layout() { ...@@ -409,9 +409,6 @@ void WebUILoginView::Layout() {
observer.OnPositionRequiresUpdate(); observer.OnPositionRequiresUpdate();
} }
void WebUILoginView::OnLocaleChanged() {
}
void WebUILoginView::ChildPreferredSizeChanged(View* child) { void WebUILoginView::ChildPreferredSizeChanged(View* child) {
Layout(); Layout();
SchedulePaint(); SchedulePaint();
......
...@@ -126,7 +126,6 @@ class WebUILoginView : public views::View, ...@@ -126,7 +126,6 @@ class WebUILoginView : public views::View,
// Overridden from views::View: // Overridden from views::View:
void Layout() override; void Layout() override;
void OnLocaleChanged() override;
void ChildPreferredSizeChanged(View* child) override; void ChildPreferredSizeChanged(View* child) override;
void AboutToRequestFocusFromTabTraversal(bool reverse) override; void AboutToRequestFocusFromTabTraversal(bool reverse) override;
......
...@@ -2620,15 +2620,6 @@ void View::PropagateThemeChanged() { ...@@ -2620,15 +2620,6 @@ void View::PropagateThemeChanged() {
OnThemeChanged(); OnThemeChanged();
} }
void View::PropagateLocaleChanged() {
{
internal::ScopedChildrenLock lock(this);
for (auto* child : base::Reversed(children_))
child->PropagateLocaleChanged();
}
OnLocaleChanged();
}
void View::PropagateDeviceScaleFactorChanged(float device_scale_factor) { void View::PropagateDeviceScaleFactorChanged(float device_scale_factor) {
{ {
internal::ScopedChildrenLock lock(this); internal::ScopedChildrenLock lock(this);
......
...@@ -1235,11 +1235,6 @@ class VIEWS_EXPORT View : public ui::LayerDelegate, ...@@ -1235,11 +1235,6 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,
// Widget::ThemeChanged(). // Widget::ThemeChanged().
virtual void OnThemeChanged() {} virtual void OnThemeChanged() {}
// Called when the locale has changed, overriding allows individual Views to
// update locale-dependent strings.
// To dispatch a locale changed notification, call Widget::LocaleChanged().
virtual void OnLocaleChanged() {}
// Tooltips ------------------------------------------------------------------ // Tooltips ------------------------------------------------------------------
// Views must invoke this when the tooltip text they are to display changes. // Views must invoke this when the tooltip text they are to display changes.
...@@ -1525,10 +1520,6 @@ class VIEWS_EXPORT View : public ui::LayerDelegate, ...@@ -1525,10 +1520,6 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,
// views in the hierarchy. // views in the hierarchy.
void PropagateThemeChanged(); void PropagateThemeChanged();
// Used to propagate locale changed notifications from the root view to all
// views in the hierarchy.
void PropagateLocaleChanged();
// Used to propagate device scale factor changed notifications from the root // Used to propagate device scale factor changed notifications from the root
// view to all views in the hierarchy. // view to all views in the hierarchy.
void PropagateDeviceScaleFactorChanged(float device_scale_factor); void PropagateDeviceScaleFactorChanged(float device_scale_factor);
......
...@@ -219,10 +219,6 @@ void RootView::ThemeChanged() { ...@@ -219,10 +219,6 @@ void RootView::ThemeChanged() {
View::PropagateThemeChanged(); View::PropagateThemeChanged();
} }
void RootView::LocaleChanged() {
View::PropagateLocaleChanged();
}
void RootView::DeviceScaleFactorChanged(float device_scale_factor) { void RootView::DeviceScaleFactorChanged(float device_scale_factor) {
View::PropagateDeviceScaleFactorChanged(device_scale_factor); View::PropagateDeviceScaleFactorChanged(device_scale_factor);
} }
......
...@@ -83,10 +83,6 @@ class VIEWS_EXPORT RootView : public View, ...@@ -83,10 +83,6 @@ class VIEWS_EXPORT RootView : public View,
// hierarchy. // hierarchy.
void ThemeChanged(); void ThemeChanged();
// Public API for broadcasting locale change notifications to this View
// hierarchy.
void LocaleChanged();
// Public API for broadcasting device scale factor change notifications to // Public API for broadcasting device scale factor change notifications to
// this View hierarchy. // this View hierarchy.
void DeviceScaleFactorChanged(float device_scale_factor); void DeviceScaleFactorChanged(float device_scale_factor);
......
...@@ -857,10 +857,6 @@ void Widget::ThemeChanged() { ...@@ -857,10 +857,6 @@ void Widget::ThemeChanged() {
root_view_->ThemeChanged(); root_view_->ThemeChanged();
} }
void Widget::LocaleChanged() {
root_view_->LocaleChanged();
}
void Widget::DeviceScaleFactorChanged(float device_scale_factor) { void Widget::DeviceScaleFactorChanged(float device_scale_factor) {
root_view_->DeviceScaleFactorChanged(device_scale_factor); root_view_->DeviceScaleFactorChanged(device_scale_factor);
} }
......
...@@ -641,10 +641,6 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate, ...@@ -641,10 +641,6 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
// changed. // changed.
void ThemeChanged(); void ThemeChanged();
// Notifies the view hierarchy contained in this widget that locale resources
// changed.
void LocaleChanged();
// Notifies the view hierarchy contained in this widget that the device scale // Notifies the view hierarchy contained in this widget that the device scale
// factor changed. // factor changed.
void DeviceScaleFactorChanged(float device_scale_factor); void DeviceScaleFactorChanged(float device_scale_factor);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment