Commit 440de562 authored by Robert Ogden's avatar Robert Ogden Committed by Commit Bot

Remove v1 HTTPS Server Previews tests

Simply removing these tests since this implementation was never
launched.

Bug: 1005295
Change-Id: Ia2799658867ad5a0be45f238f0def5b95800ef32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815883Reviewed-by: default avatarTarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698518}
parent 412c516f
...@@ -15,38 +15,21 @@ from decorators import ChromeVersionBeforeM ...@@ -15,38 +15,21 @@ from decorators import ChromeVersionBeforeM
from selenium.common.exceptions import TimeoutException from selenium.common.exceptions import TimeoutException
NAV_THROTTLE_VERSION = "v1_NavThrottle"
URL_LOADER_VERSION = "v2_URLLoader"
LITEPAGES_REGEXP = r'https://\w+\.litepages\.googlezip\.net/.*' LITEPAGES_REGEXP = r'https://\w+\.litepages\.googlezip\.net/.*'
# These are integration tests for server provided previews and the # These are integration tests for server provided previews and the
# protocol that supports them. This class is intended as an abstract base class # protocol that supports them.
# to allow the two versions of this feature implementation to reuse the same class HttpsPreviews(IntegrationTest):
# tests.
class HttpsPreviewsBaseClass():
# Abstract function for subclasses to override.
def getVersion(self):
raise Exception( "Please override this method")
def EnableLitePageServerPreviewsAndInit(self, t): def EnableLitePageServerPreviewsAndInit(self, t):
version = self.getVersion()
# These feature flags are common to both versions.
t.EnableChromeFeature('Previews') t.EnableChromeFeature('Previews')
t.EnableChromeFeature('LitePageServerPreviews') t.EnableChromeFeature('LitePageServerPreviews')
t.EnableChromeFeature('HTTPSServerPreviewsUsingURLLoader')
# RLH and NoScript may disable use of LitePageRedirect Previews. # RLH and NoScript may disable use of LitePageRedirect Previews.
t.DisableChromeFeature('ResourceLoadingHints') t.DisableChromeFeature('ResourceLoadingHints')
t.DisableChromeFeature('NoScriptPreviews') t.DisableChromeFeature('NoScriptPreviews')
if version == NAV_THROTTLE_VERSION:
# No additional flags here, but explicitly check it given the else below.
pass
elif version == URL_LOADER_VERSION:
t.EnableChromeFeature('HTTPSServerPreviewsUsingURLLoader')
else:
raise Exception('"%s" is not a valid version' % version)
t.AddChromeArg('--enable-spdy-proxy-auth') t.AddChromeArg('--enable-spdy-proxy-auth')
t.AddChromeArg('--dont-require-litepage-redirect-infobar') t.AddChromeArg('--dont-require-litepage-redirect-infobar')
t.AddChromeArg('--ignore-previews-blacklist') t.AddChromeArg('--ignore-previews-blacklist')
...@@ -274,14 +257,6 @@ class HttpsPreviewsBaseClass(): ...@@ -274,14 +257,6 @@ class HttpsPreviewsBaseClass():
ok_responses += 1 ok_responses += 1
self.assertNotEqual(0, ok_responses) self.assertNotEqual(0, ok_responses)
class HttpsPreviewsNavigationThrottle(HttpsPreviewsBaseClass, IntegrationTest):
def getVersion(self):
return NAV_THROTTLE_VERSION
class HttpsPreviewsURLLoader(HttpsPreviewsBaseClass, IntegrationTest):
def getVersion(self):
return URL_LOADER_VERSION
# Verifies that if a streaming preview is being served but needs to be # Verifies that if a streaming preview is being served but needs to be
# aborted, changing location.href will load the original page. # aborted, changing location.href will load the original page.
# #
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment