Commit 44257487 authored by Imranur Rahman's avatar Imranur Rahman Committed by Commit Bot

Removing unused ClientToServerResponse member and

method.

stream_metadata and stream_data were intended for some sort
of "streaming response" mode. But it was never used. So, we
are removing the unnecessary fields and corresponding proto
messages.

Bug: 1007190
Signed-off-by: default avatarImranur Rahman <i.rahman@samsung.com>
Change-Id: Ic3cfca34f1d4cf20472b9d40b8a0ab314ca84983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821500Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699693}
parent 5f9171da
...@@ -910,29 +910,6 @@ message GetUpdatesResponse { ...@@ -910,29 +910,6 @@ message GetUpdatesResponse {
repeated DataTypeContext context_mutations = 7; repeated DataTypeContext context_mutations = 7;
}; };
// The metadata response for GetUpdatesMessage. This response is sent when
// streaming is set to true in the request. It is prefixed with a length
// delimiter, which is encoded in varint.
message GetUpdatesMetadataResponse {
// Approximate count of changes remaining. Detailed comment is available in
// GetUpdatesResponse.
optional int64 changes_remaining = 1;
// Opaque, per-datatype timestamp-like tokens. Detailed comment is available
// in GetUpdatesResponse.
repeated DataTypeProgressMarker new_progress_marker = 2;
};
// The streaming response message for GetUpdatesMessage. This message is sent
// when streaming is set to true in the request. There may be multiple
// GetUpdatesStreamingResponse messages in a response. This type of messages
// is preceded by GetUpdatesMetadataResponse. It is prefixed with a length
// delimiter, which is encoded in varint.
message GetUpdatesStreamingResponse {
// New sync entries that the client should apply.
repeated SyncEntity entries = 1;
};
message ClientToServerResponse { message ClientToServerResponse {
optional CommitResponse commit = 1; optional CommitResponse commit = 1;
optional GetUpdatesResponse get_updates = 2; optional GetUpdatesResponse get_updates = 2;
...@@ -958,10 +935,10 @@ message ClientToServerResponse { ...@@ -958,10 +935,10 @@ message ClientToServerResponse {
optional ClientCommand client_command = 7; optional ClientCommand client_command = 7;
optional ProfilingData profiling_data = 8; optional ProfilingData profiling_data = 8;
reserved 9; reserved 9;
optional GetUpdatesMetadataResponse stream_metadata = 10; reserved 10;
// If GetUpdatesStreamingResponse is contained in the ClientToServerResponse, reserved "stream_metadata";
// none of the other fields (error_code and etc) will be set. reserved 11;
optional GetUpdatesStreamingResponse stream_data = 11; reserved "stream_data";
// The data types whose storage has been migrated. Present when the value of // The data types whose storage has been migrated. Present when the value of
// error_code is MIGRATION_DONE. // error_code is MIGRATION_DONE.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment