Commit 442661c8 authored by Elly Fong-Jones's avatar Elly Fong-Jones Committed by Commit Bot

mac: re-enable two BrowserKeyEventsTest tests

This change re-enables NormalKeyEvents and EditorKeyBindings on Mac.
Both have repeatedly passed locally. AccessKeys is still disabled; it
has some Mac-specific codepaths which I don't yet understand and which
seem not to work.

Bug: 222296,81451
Change-Id: I021d7f6765393975221b1cdd3e8768715e36bd93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122807Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753756}
parent 1081de2f
...@@ -294,13 +294,7 @@ class BrowserKeyEventsTest : public InProcessBrowserTest { ...@@ -294,13 +294,7 @@ class BrowserKeyEventsTest : public InProcessBrowserTest {
} }
}; };
#if defined(OS_MACOSX) IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, NormalKeyEvents) {
// http://crbug.com/81451
#define MAYBE_NormalKeyEvents DISABLED_NormalKeyEvents
#else
#define MAYBE_NormalKeyEvents NormalKeyEvents
#endif
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, MAYBE_NormalKeyEvents) {
static const KeyEventTestData kTestNoInput[] = { static const KeyEventTestData kTestNoInput[] = {
// a // a
{ ui::VKEY_A, false, false, false, false, { ui::VKEY_A, false, false, false, false,
...@@ -701,9 +695,6 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, ReservedAccelerators) { ...@@ -701,9 +695,6 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, ReservedAccelerators) {
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, EditorKeyBindings) { IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, EditorKeyBindings) {
// TODO(kbr): re-enable: http://crbug.com/222296
return;
static const KeyEventTestData kTestCtrlA = { static const KeyEventTestData kTestCtrlA = {
ui::VKEY_A, true, false, false, false, ui::VKEY_A, true, false, false, false,
false, false, false, false, 4, false, false, false, false, 4,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment