[Code health] Fix gn check issues in //extensions/browser/api/storage

Bug: 1158969
Change-Id: Icbf7391b764b776682336fb1398d9f141c9eb21c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601641
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841209}

.gn

@@ -122,7 +122,6 @@ no_check_targets = [
   "//extensions/browser/api/sockets_tcp:*",  # 6 errors
   "//extensions/browser/api/sockets_tcp_server:*",  # 8 errors
   "//extensions/browser/api/sockets_udp:*",  # 9 errors
-  "//extensions/browser/api/storage:*",  # 9 errors
   "//extensions/browser/api/system_cpu:*",  # 1 error
   "//extensions/browser/api/system_display:*",  # 3 errors
   "//extensions/browser/api/system_info:*",  # 8 errors

chrome/browser/BUILD.gn

@@ -4218,7 +4218,10 @@ static_library("browser") {
       ]
     }
     if (enable_extensions) {
-      deps += [ "//extensions/browser" ]
+      deps += [
+        "//extensions/browser",
+        "//extensions/browser/api:api_implementations",
+      ]
     }
 
     if (is_posix || is_fuchsia) {

chrome/browser/chromeos/BUILD.gn

@@ -319,6 +319,7 @@ source_set("chromeos") {
     "//components/user_manager",
     "//components/user_prefs:user_prefs",
     "//components/vector_icons",
+    "//extensions/browser/api:api_implementations",
     "//media/capture/video/chromeos/public:public",
 
     # This depends directly on the variations target, rather than just

chrome/browser/extensions/BUILD.gn

@@ -877,6 +877,7 @@ static_library("extensions") {
     "//extensions:extensions_resources",
     "//extensions/browser",
     "//extensions/browser:core_api_provider",
+    "//extensions/browser/api:api_implementations",
     "//extensions/buildflags",
     "//extensions/common",
     "//extensions/common/api",

chrome/browser/extensions/api/BUILD.gn

@@ -32,6 +32,8 @@ function_registration("api_registration") {
     "//components/zoom",
     "//content/public/browser",
     "//extensions/browser",
+    "//extensions/browser/api:api_implementations",
+    "//extensions/common/api",
 
     # Different APIs include some headers from chrome/common that in turn
     # include generated headers from these targets.
@@ -42,5 +44,4 @@ function_registration("api_registration") {
     "//third_party/metrics_proto",
     "//ui/accessibility:ax_enums_mojo",
   ]
-  deps += [ "//extensions/common/api" ]
 }

extensions/BUILD.gn

@@ -154,6 +154,7 @@ static_library("test_support") {
     "//content/test:test_support",
     "//extensions/browser",
     "//extensions/browser:test_support",
+    "//extensions/browser/api/storage",
     "//extensions/common",
     "//extensions/common:core_api_provider",
     "//extensions/common/api",

extensions/browser/BUILD.gn

@@ -36,6 +36,7 @@ source_set("browser_context_keyed_service_factories") {
     "//build:chromeos_buildflags",
     "//extensions/browser:browser_sources",
     "//extensions/browser/api",
+    "//extensions/browser/api:api_implementations",
   ]
 }
 

extensions/browser/api/BUILD.gn

@@ -39,6 +39,14 @@ source_set("api") {
     "//base",
     "//content/public/browser",
     "//content/public/common",
+    "//extensions/common",
+    "//ipc",
+  ]
+
+  # TODO(crbug/1158984): remove these deps. The core API system should not
+  # include specific API implementations; these should instead be moved to
+  # api_implementations below (and only included in the final Chrome target).
+  public_deps += [
     "//extensions/browser/api/activity_log",
     "//extensions/browser/api/alarms",
     "//extensions/browser/api/app_current_window_internal",
@@ -75,7 +83,6 @@ source_set("api") {
     "//extensions/browser/api/sockets_tcp",
     "//extensions/browser/api/sockets_tcp_server",
     "//extensions/browser/api/sockets_udp",
-    "//extensions/browser/api/storage",
     "//extensions/browser/api/system_cpu",
     "//extensions/browser/api/system_display",
     "//extensions/browser/api/system_info",
@@ -86,8 +93,6 @@ source_set("api") {
     "//extensions/browser/api/usb",
     "//extensions/browser/api/virtual_keyboard_private",
     "//extensions/browser/api/web_request",
-    "//extensions/common",
-    "//ipc",
   ]
 
   deps = [
@@ -152,6 +157,58 @@ source_set("api") {
   }
 }
 
+group("api_implementations") {
+  public_deps = [
+    "//extensions/browser/api/activity_log",
+    "//extensions/browser/api/alarms",
+    "//extensions/browser/api/app_current_window_internal",
+    "//extensions/browser/api/app_runtime",
+    "//extensions/browser/api/app_window",
+    "//extensions/browser/api/audio",
+    "//extensions/browser/api/automation_internal",
+    "//extensions/browser/api/bluetooth",
+    "//extensions/browser/api/bluetooth_low_energy",
+    "//extensions/browser/api/bluetooth_socket",
+    "//extensions/browser/api/cast_channel",
+    "//extensions/browser/api/declarative",
+    "//extensions/browser/api/declarative_content",
+    "//extensions/browser/api/declarative_net_request",
+    "//extensions/browser/api/declarative_webrequest",
+    "//extensions/browser/api/display_source",
+    "//extensions/browser/api/dns",
+    "//extensions/browser/api/feedback_private",
+    "//extensions/browser/api/file_handlers",
+    "//extensions/browser/api/file_system",
+    "//extensions/browser/api/hid",
+    "//extensions/browser/api/idle",
+    "//extensions/browser/api/management",
+    "//extensions/browser/api/messaging",
+    "//extensions/browser/api/metrics_private",
+    "//extensions/browser/api/mime_handler_private",
+    "//extensions/browser/api/networking_private",
+    "//extensions/browser/api/power",
+    "//extensions/browser/api/printer_provider",
+    "//extensions/browser/api/printer_provider_internal",
+    "//extensions/browser/api/runtime",
+    "//extensions/browser/api/serial",
+    "//extensions/browser/api/socket",
+    "//extensions/browser/api/sockets_tcp",
+    "//extensions/browser/api/sockets_tcp_server",
+    "//extensions/browser/api/sockets_udp",
+    "//extensions/browser/api/storage",
+    "//extensions/browser/api/system_cpu",
+    "//extensions/browser/api/system_display",
+    "//extensions/browser/api/system_info",
+    "//extensions/browser/api/system_memory",
+    "//extensions/browser/api/system_network",
+    "//extensions/browser/api/system_storage",
+    "//extensions/browser/api/test",
+    "//extensions/browser/api/usb",
+    "//extensions/browser/api/virtual_keyboard_private",
+    "//extensions/browser/api/web_request",
+  ]
+}
+
 function_registration("api_registration") {
   sources = extensions_api_schema_files + extensions_api_uncompiled_sources
   impl_dir = "//extensions/browser/api"

extensions/browser/api/storage/BUILD.gn

@@ -26,7 +26,11 @@ source_set("storage") {
     "weak_unlimited_settings_storage.h",
   ]
 
-  deps = [ "//extensions/common/api" ]
+  deps = [
+    "//extensions/browser/api",
+    "//extensions/common",
+    "//extensions/common/api",
+  ]
 
   public_deps = [ "//extensions/browser:browser_sources" ]
 }