Commit 44700b6e authored by Victor Vasiliev's avatar Victor Vasiliev Committed by Commit Bot

Move QUIC trace proto out of the main net component due to binary size

R=rch@chromium.org

Change-Id: Icd0d30ca1665e843d13c9d3521d3038a08a8488b
Reviewed-on: https://chromium-review.googlesource.com/1043007
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556360}
parent e2028bd7
...@@ -1271,8 +1271,6 @@ component("net") { ...@@ -1271,8 +1271,6 @@ component("net") {
"quic/core/quic_tag.h", "quic/core/quic_tag.h",
"quic/core/quic_time.cc", "quic/core/quic_time.cc",
"quic/core/quic_time.h", "quic/core/quic_time.h",
"quic/core/quic_trace_visitor.cc",
"quic/core/quic_trace_visitor.h",
"quic/core/quic_transmission_info.cc", "quic/core/quic_transmission_info.cc",
"quic/core/quic_transmission_info.h", "quic/core/quic_transmission_info.h",
"quic/core/quic_types.cc", "quic/core/quic_types.cc",
...@@ -2281,7 +2279,6 @@ proto_library("net_quic_proto") { ...@@ -2281,7 +2279,6 @@ proto_library("net_quic_proto") {
sources = [ sources = [
"quic/core/proto/cached_network_parameters.proto", "quic/core/proto/cached_network_parameters.proto",
"quic/core/proto/quic_trace.proto",
"quic/core/proto/source_address_token.proto", "quic/core/proto/source_address_token.proto",
] ]
cc_generator_options = "dllexport_decl=NET_EXPORT_PRIVATE:" cc_generator_options = "dllexport_decl=NET_EXPORT_PRIVATE:"
...@@ -2293,6 +2290,17 @@ proto_library("net_quic_proto") { ...@@ -2293,6 +2290,17 @@ proto_library("net_quic_proto") {
extra_configs = [ "//build/config/compiler:wexit_time_destructors" ] extra_configs = [ "//build/config/compiler:wexit_time_destructors" ]
} }
proto_library("net_quic_trace_proto") {
visibility = [ ":simple_quic_tools" ]
sources = [
"quic/core/proto/quic_trace.proto",
]
component_build_force_source_set = true
extra_configs = [ "//build/config/compiler:wexit_time_destructors" ]
}
if (!is_proto_quic) { if (!is_proto_quic) {
static_library("extras") { static_library("extras") {
sources = [ sources = [
...@@ -3305,6 +3313,8 @@ source_set("quic_test_tools") { ...@@ -3305,6 +3313,8 @@ source_set("quic_test_tools") {
source_set("simple_quic_tools") { source_set("simple_quic_tools") {
sources = [ sources = [
"quic/core/quic_trace_visitor.cc",
"quic/core/quic_trace_visitor.h",
"tools/quic/chlo_extractor.cc", "tools/quic/chlo_extractor.cc",
"tools/quic/chlo_extractor.h", "tools/quic/chlo_extractor.h",
"tools/quic/quic_client_base.cc", "tools/quic/quic_client_base.cc",
...@@ -3353,8 +3363,10 @@ source_set("simple_quic_tools") { ...@@ -3353,8 +3363,10 @@ source_set("simple_quic_tools") {
] ]
deps = [ deps = [
":net", ":net",
":net_quic_trace_proto",
"//base", "//base",
"//base/third_party/dynamic_annotations", "//base/third_party/dynamic_annotations",
"//third_party/protobuf:protobuf_lite",
"//url", "//url",
] ]
} }
......
...@@ -14,7 +14,7 @@ namespace net { ...@@ -14,7 +14,7 @@ namespace net {
// Records a QUIC trace protocol buffer for a QuicConnection. It's the // Records a QUIC trace protocol buffer for a QuicConnection. It's the
// responsibility of the user of this visitor to process or store the resulting // responsibility of the user of this visitor to process or store the resulting
// trace, which can be accessed via trace(). // trace, which can be accessed via trace().
class QUIC_EXPORT_PRIVATE QuicTraceVisitor : public QuicConnectionDebugVisitor { class QuicTraceVisitor : public QuicConnectionDebugVisitor {
public: public:
explicit QuicTraceVisitor(const QuicConnection* connection); explicit QuicTraceVisitor(const QuicConnection* connection);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment