Update crostini.containers when creating and destroying LXD containers

Change-Id: If1ce2c1dc88929cce71f60f3980521f8209e8078
Reviewed-on: https://chromium-review.googlesource.com/c/1429300
Commit-Queue: Fergus Dall <sidereal@google.com>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626995}

chrome/browser/chromeos/crostini/crostini_manager.cc

@@ -1935,6 +1935,8 @@ void CrostiniManager::OnLxdContainerCreated(
       break;
     case vm_tools::cicerone::LxdContainerCreatedSignal::CREATED:
       result = CrostiniResult::SUCCESS;
+      AddNewLxdContainerToPrefs(profile_, signal.vm_name(),
+                                signal.container_name());
       break;
     case vm_tools::cicerone::LxdContainerCreatedSignal::DOWNLOAD_TIMED_OUT:
       result = CrostiniResult::CONTAINER_DOWNLOAD_TIMED_OUT;

chrome/browser/chromeos/crostini/crostini_remover.cc

@@ -101,6 +101,8 @@ void CrostiniRemover::StopConciergeFinished(bool is_successful) {
       CrostiniManager::GetForProfile(profile_)->UninstallTerminaComponent()) {
     profile_->GetPrefs()->SetBoolean(prefs::kCrostiniEnabled, false);
     profile_->GetPrefs()->ClearPref(prefs::kCrostiniLastDiskSize);
+    profile_->GetPrefs()->Set(prefs::kCrostiniContainers,
+                              base::Value(base::Value::Type::LIST));
   }
   std::move(callback_).Run(CrostiniResult::SUCCESS);
 }

chrome/browser/chromeos/crostini/crostini_util.cc

@@ -4,6 +4,8 @@
 
 #include "chrome/browser/chromeos/crostini/crostini_util.h"
 
+#include <utility>
+
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/feature_list.h"
@@ -408,4 +410,17 @@ bool IsUnaffiliatedCrostiniAllowedByPolicy() {
   return true;
 }
 
+void AddNewLxdContainerToPrefs(Profile* profile,
+                               std::string vm_name,
+                               std::string container_name) {
+  auto* pref_service = profile->GetPrefs();
+
+  base::Value new_container(base::Value::Type::DICTIONARY);
+  new_container.SetKey("vm_name", base::Value(vm_name));
+  new_container.SetKey("container_name", base::Value(container_name));
+
+  ListPrefUpdate updater(pref_service, crostini::prefs::kCrostiniContainers);
+  updater->GetList().emplace_back(std::move(new_container));
+}
+
 }  // namespace crostini

chrome/browser/chromeos/crostini/crostini_util.h

@@ -139,6 +139,11 @@ constexpr char kCrostiniDefaultImageAlias[] = "debian/stretch";
 // policy.
 bool IsUnaffiliatedCrostiniAllowedByPolicy();
 
+// Add a newly created LXD container to the kCrostiniContainers pref
+void AddNewLxdContainerToPrefs(Profile* profile,
+                               std::string vm_name,
+                               std::string container_name);
+
 }  // namespace crostini
 
 #endif  // CHROME_BROWSER_CHROMEOS_CROSTINI_CROSTINI_UTIL_H_

chrome/browser/ui/views/crostini/crostini_installer_view.cc

@@ -149,6 +149,13 @@ bool CrostiniInstallerView::Accept() {
   UpdateState(State::INSTALL_START);
   profile_->GetPrefs()->SetBoolean(crostini::prefs::kCrostiniEnabled, true);
 
+  // The default value of kCrostiniContainers is set to migrate existing
+  // crostini users who don't have the pref set. If crostini is being installed,
+  // then we know the user must not actually have any containers yet, so we set
+  // this pref to the empty list.
+  profile_->GetPrefs()->Set(crostini::prefs::kCrostiniContainers,
+                            base::Value(base::Value::Type::LIST));
+
   progress_bar_->SetVisible(true);
 
   // |learn_more_link_| should only be present in State::PROMPT.