Commit 44910c30 authored by Kenneth Russell's avatar Kenneth Russell Committed by Commit Bot

Set should_retry_with_patch=false for Chromium GPU tests.

The GPU tests act much like integration tests for the entire browser,
and tend to uncover flakiness bugs more readily than other test
suites. In order to surface any flakiness more readily to the
developer of the CL which is introducing it, we disable retries with
patch on the commit queue.

Bug: 906166
Change-Id: Iee56100a774377b9172325627da4694ce0a15009
Reviewed-on: https://chromium-review.googlesource.com/c/1357569Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613319}
parent 413b993f
This source diff could not be displayed because it is too large. You can view the blob instead.
This diff is collapsed.
This diff is collapsed.
......@@ -600,6 +600,13 @@ class BBJSONGenerator(object):
# aren't idempotent yet. https://crbug.com/549140.
result['swarming']['idempotent'] = False
# The GPU tests act much like integration tests for the entire browser, and
# tend to uncover flakiness bugs more readily than other test suites. In
# order to surface any flakiness more readily to the developer of the CL
# which is introducing it, we disable retries with patch on the commit
# queue.
result['should_retry_with_patch'] = False
args = [
test_to_run,
'--show-stdout',
......
......@@ -1053,6 +1053,7 @@ GPU_TELEMETRY_TEST_OUTPUT = """\
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "foo_tests",
"should_retry_with_patch": false,
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
......@@ -1216,6 +1217,7 @@ GPU_DIMENSIONS_WATERFALL_OUTPUT = """\
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "foo_test",
"should_retry_with_patch": false,
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment