Commit 44aa0822 authored by Karan Bhatia's avatar Karan Bhatia Committed by Commit Bot

Revert "Disable JSONSchemaCompiler tests"

This reverts commit 2c7db28c.

Reason for revert: The test failures were caused due to crbug.com/gn/215 which caused spurious failures in 
incremental rebuilds. The corresponding GN roll has now been reverted.

Original change's description:
> Disable JSONSchemaCompiler tests
>
> The tests started to fail on
> https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests when
> https://crbug.com/1113513#c16 was landed.
> The revert was supposed to fix other failures.
>
> Tbr: karandeepb@chromium.org
> Bug: 1113513
> Change-Id: Ia800eba3f90cf3be44bd800c999d7a694f819573
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517567
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: Christian Dullweber <dullweber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823954}

TBR=karandeepb@chromium.org,dullweber@chromium.org

Change-Id: I30e936c84c9dcae8e2702eed89e320ad7f4ff5a1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1113513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518308Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824168}
parent b4e95a6f
......@@ -640,8 +640,7 @@ TEST_P(SingleRulesetTest, InvalidJSONRules_StrongTypes) {
// Ensures that rules which can't be parsed are ignored and cause an install
// warning.
// Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST_P(SingleRulesetTest, DISABLED_InvalidJSONRules_Parsed) {
TEST_P(SingleRulesetTest, InvalidJSONRules_Parsed) {
const char* kRules = R"(
[
{
......
......@@ -146,8 +146,7 @@ TEST(JsonSchemaCompilerErrorTest, WrongParameterCreationType) {
}
}
// Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_WrongTypeValueType) {
TEST(JsonSchemaCompilerErrorTest, WrongTypeValueType) {
{
auto value = std::make_unique<base::DictionaryValue>();
EXPECT_TRUE(EqualsUtf16("", GetPopulateError<errors::ObjectType>(*value)));
......@@ -228,8 +227,8 @@ TEST(JsonSchemaCompilerErrorTest, BadEnumValue) {
}
// Warn but don't fail out errors
// Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_WarnOnOptionalFailure) {
TEST(JsonSchemaCompilerErrorTest, WarnOnOptionalFailure) {
{
std::unique_ptr<base::DictionaryValue> value =
Dictionary("string", std::make_unique<Value>("bling"));
......@@ -249,8 +248,7 @@ TEST(JsonSchemaCompilerErrorTest, DISABLED_WarnOnOptionalFailure) {
}
}
// Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_OptionalBinaryTypeFailure) {
TEST(JsonSchemaCompilerErrorTest, OptionalBinaryTypeFailure) {
{
std::unique_ptr<base::DictionaryValue> value =
Dictionary("data", std::make_unique<Value>(Value::Type::BINARY));
......@@ -271,8 +269,7 @@ TEST(JsonSchemaCompilerErrorTest, DISABLED_OptionalBinaryTypeFailure) {
}
}
// Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_OptionalArrayTypeFailure) {
TEST(JsonSchemaCompilerErrorTest, OptionalArrayTypeFailure) {
{
std::unique_ptr<base::DictionaryValue> value =
Dictionary("TheArray", std::make_unique<base::ListValue>());
......@@ -290,8 +287,7 @@ TEST(JsonSchemaCompilerErrorTest, DISABLED_OptionalArrayTypeFailure) {
}
}
// Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_OptionalUnableToPopulateArray) {
TEST(JsonSchemaCompilerErrorTest, OptionalUnableToPopulateArray) {
{
std::unique_ptr<base::ListValue> params_value =
List(std::make_unique<Value>(5));
......@@ -313,8 +309,7 @@ TEST(JsonSchemaCompilerErrorTest, DISABLED_OptionalUnableToPopulateArray) {
}
}
// Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_MultiplePopulationErrors) {
TEST(JsonSchemaCompilerErrorTest, MultiplePopulationErrors) {
{
std::unique_ptr<base::DictionaryValue> value =
Dictionary("TheArray", std::make_unique<Value>(5));
......@@ -333,8 +328,7 @@ TEST(JsonSchemaCompilerErrorTest, DISABLED_MultiplePopulationErrors) {
}
}
// Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_TooManyKeys) {
TEST(JsonSchemaCompilerErrorTest, TooManyKeys) {
{
std::unique_ptr<base::DictionaryValue> value =
Dictionary("string", std::make_unique<Value>("yes"));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment