Commit 44bbfd8d authored by brettw@chromium.org's avatar brettw@chromium.org

Fix PageLoadTest.Reliability which I broke in my previous checkin to make the

throbber more responsive. The issue is that I changed the meaning of LOAD_START
from indicating that the renderer started loading to indicating when the
browser told the renderer to start loading. This means it now looks like we
started loading "about:crash" whereas before it didn't.

I think this change is reasonable and how we could about:crash in this
respect isn't important, so I just removed the failing checks.
Review URL: http://codereview.chromium.org/99118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14720 0039d316-1c4b-4281-b951-d872f2087c98
parent 329581b6
...@@ -338,17 +338,13 @@ class PageLoadTest : public UITest { ...@@ -338,17 +338,13 @@ class PageLoadTest : public UITest {
// Go to "about:crash" // Go to "about:crash"
NavigateToURLLogResult(GURL(crash_url), log_file, &metrics); NavigateToURLLogResult(GURL(crash_url), log_file, &metrics);
// Page load crashed and test automation timed out.
EXPECT_EQ(NAVIGATION_TIME_OUT, metrics.result);
// Found a crash dump // Found a crash dump
EXPECT_EQ(1, metrics.crash_dump_count) << kFailedNoCrashService; EXPECT_EQ(1, metrics.crash_dump_count) << kFailedNoCrashService;
// Browser did not crash, and exited cleanly. // Browser did not crash, and exited cleanly.
EXPECT_EQ(true, metrics.browser_clean_exit); EXPECT_EQ(true, metrics.browser_clean_exit);
EXPECT_EQ(1, metrics.browser_launch_count); EXPECT_EQ(1, metrics.browser_launch_count);
// Only starting page was loaded. // Only the renderer should have crashed.
EXPECT_EQ(1, metrics.page_load_count);
EXPECT_EQ(0, metrics.browser_crash_count); EXPECT_EQ(0, metrics.browser_crash_count);
// Renderer crashed.
EXPECT_EQ(1, metrics.renderer_crash_count); EXPECT_EQ(1, metrics.renderer_crash_count);
EXPECT_EQ(0, metrics.plugin_crash_count); EXPECT_EQ(0, metrics.plugin_crash_count);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment