Move a SharedPref from HistoryManager to ChromePreferenceKeys

Register it in ChromePreferenceKeys and use SharedPreferencesManager
consistently instead of SharedPreferences directly.

Bug: 1022108
Change-Id: I1c0bea6950d1a52d4213d11d421d89ce3b87ea01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003454
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733040}

chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java

@@ -32,9 +32,11 @@ import org.chromium.chrome.browser.ChromeTabbedActivity;
 import org.chromium.chrome.browser.IntentHandler;
 import org.chromium.chrome.browser.document.ChromeLauncherActivity;
 import org.chromium.chrome.browser.favicon.LargeIconBridge;
+import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
 import org.chromium.chrome.browser.preferences.Pref;
 import org.chromium.chrome.browser.preferences.PrefChangeRegistrar;
 import org.chromium.chrome.browser.preferences.PrefChangeRegistrar.PrefObserver;
+import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
 import org.chromium.chrome.browser.profiles.Profile;
 import org.chromium.chrome.browser.settings.SettingsLauncher;
 import org.chromium.chrome.browser.settings.privacy.ClearBrowsingDataTabsFragment;
@@ -66,7 +68,6 @@ public class HistoryManager implements OnMenuItemClickListener, SignInStateObser
     private static final int FAVICON_MAX_CACHE_SIZE_BYTES =
             10 * ConversionUtils.BYTES_PER_MEGABYTE; // 10MB
     private static final String METRICS_PREFIX = "Android.HistoryPage.";
-    private static final String PREF_SHOW_HISTORY_INFO = "history_home_show_info";
 
     // Keep consistent with the UMA constants on the WebUI history page (history/constants.js).
     private static final int UMA_MAX_BUCKET_VALUE = 1000;
@@ -112,8 +113,8 @@ public class HistoryManager implements OnMenuItemClickListener, SignInStateObser
     @SuppressWarnings("unchecked") // mSelectableListLayout
     public HistoryManager(Activity activity, boolean isSeparateActivity,
             SnackbarManager snackbarManager, boolean isIncognito) {
-        mShouldShowInfoHeader =
-                ContextUtils.getAppSharedPreferences().getBoolean(PREF_SHOW_HISTORY_INFO, true);
+        mShouldShowInfoHeader = SharedPreferencesManager.getInstance().readBoolean(
+                ChromePreferenceKeys.HISTORY_SHOW_HISTORY_INFO, true);
         mActivity = activity;
         mIsSeparateActivity = isSeparateActivity;
         mSnackbarManager = snackbarManager;
@@ -266,10 +267,8 @@ public class HistoryManager implements OnMenuItemClickListener, SignInStateObser
             return true;
         } else if (item.getItemId() == R.id.info_menu_id) {
             mShouldShowInfoHeader = !mShouldShowInfoHeader;
-            ContextUtils.getAppSharedPreferences()
-                    .edit()
-                    .putBoolean(PREF_SHOW_HISTORY_INFO, mShouldShowInfoHeader)
-                    .apply();
+            SharedPreferencesManager.getInstance().writeBoolean(
+                    ChromePreferenceKeys.HISTORY_SHOW_HISTORY_INFO, mShouldShowInfoHeader);
             mToolbar.updateInfoMenuItem(shouldShowInfoButton(), shouldShowInfoHeaderIfAvailable());
             mHistoryAdapter.setPrivacyDisclaimer();
         }

chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java

@@ -396,6 +396,8 @@ public final class ChromePreferenceKeys {
     public static final String FONT_USER_FONT_SCALE_FACTOR = "user_font_scale_factor";
     public static final String FONT_USER_SET_FORCE_ENABLE_ZOOM = "user_set_force_enable_zoom";
 
+    public static final String HISTORY_SHOW_HISTORY_INFO = "history_home_show_info";
+
     /** Keys used to save settings related to homepage. */
     public static final String HOMEPAGE_CUSTOM_URI = "homepage_custom_uri";
     public static final String HOMEPAGE_ENABLED = "homepage";
@@ -760,6 +762,7 @@ public final class ChromePreferenceKeys {
                 FLAGS_CACHED_TAB_GROUPS_ANDROID_ENABLED,
                 FONT_USER_FONT_SCALE_FACTOR,
                 FONT_USER_SET_FORCE_ENABLE_ZOOM,
+                HISTORY_SHOW_HISTORY_INFO,
                 HOMEPAGE_CUSTOM_URI,
                 HOMEPAGE_ENABLED,
                 HOMEPAGE_USE_DEFAULT_URI,