Commit 44e47f76 authored by David Bertoni's avatar David Bertoni Committed by Commit Bot

[Extensions] Re-enable some tests that are no longer flaky.

These IncognitoApiTest tests were disabled a long time ago for
flakiness, but they passed 3000 iterations on the bots with no
issues.

Bug: 89054, 120484
Change-Id: I59b22ef5f7daa6d040279d388a2f4d90770c9f90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270687Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786836}
parent 11a8c153
......@@ -87,21 +87,15 @@ IN_PROC_BROWSER_TEST_F(IncognitoApiTest, IncognitoYesScript) {
}
// Tests that an extension which is enabled for incognito mode doesn't
// accidentially create and incognito profile.
// Test disabled due to http://crbug.com/89054.
IN_PROC_BROWSER_TEST_F(IncognitoApiTest, DISABLED_DontCreateIncognitoProfile) {
// accidentally create and incognito profile.
IN_PROC_BROWSER_TEST_F(IncognitoApiTest, DontCreateIncognitoProfile) {
ASSERT_FALSE(browser()->profile()->HasPrimaryOTRProfile());
ASSERT_TRUE(RunExtensionTestIncognito(
"incognito/dont_create_profile")) << message_;
ASSERT_FALSE(browser()->profile()->HasPrimaryOTRProfile());
}
#if defined(OS_WIN) || defined(OS_MACOSX)
// http://crbug.com/120484
IN_PROC_BROWSER_TEST_F(IncognitoApiTest, DISABLED_Incognito) {
#else
IN_PROC_BROWSER_TEST_F(IncognitoApiTest, Incognito) {
#endif
ResultCatcher catcher;
// Open incognito window and navigate to test page.
......@@ -117,8 +111,7 @@ IN_PROC_BROWSER_TEST_F(IncognitoApiTest, Incognito) {
// Tests that the APIs in an incognito-enabled split-mode extension work
// properly.
// http://crbug.com/120484
IN_PROC_BROWSER_TEST_F(IncognitoApiTest, DISABLED_IncognitoSplitMode) {
IN_PROC_BROWSER_TEST_F(IncognitoApiTest, IncognitoSplitMode) {
// We need 2 ResultCatchers because we'll be running the same test in both
// regular and incognito mode.
ResultCatcher catcher;
......@@ -149,12 +142,7 @@ IN_PROC_BROWSER_TEST_F(IncognitoApiTest, DISABLED_IncognitoSplitMode) {
// Tests that the APIs in an incognito-disabled extension don't see incognito
// events or callbacks.
#if defined(OS_WIN)
// http://crbug.com/120484
IN_PROC_BROWSER_TEST_F(IncognitoApiTest, DISABLED_IncognitoDisabled) {
#else
IN_PROC_BROWSER_TEST_F(IncognitoApiTest, IncognitoDisabled) {
#endif
ResultCatcher catcher;
ExtensionTestMessageListener listener("createIncognitoTab", true);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment