Skip to content

GitLab

T
tangled
Commit 44f1ce3d authored by Xianzhu Wang's avatar Xianzhu Wang Committed by Commit Bot
Browse files
Options

Fix DCHECK failure with <input type="file" style="display: flex"> 

Let FileInputUploadControl::PaintedOutputHasNoEffectRegardlessOfSize()
return false because it always paints the button.

Bug: 1009827
Change-Id: Ib74ea880c3b984adf3eee707f8285508e3300b53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836659
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702726}
parent da2c4284
Hide whitespace changes
Inline Side-by-side
Showing with 9 additions and 0 deletions
third_party/blink/renderer/core/layout/layout_file_upload_control.h
View file @ 44f1ce3d
...@@ -55,6 +55,10 @@ class CORE_EXPORT LayoutFileUploadControl final : public LayoutBlockFlow { ...@@ -55,6 +55,10 @@ class CORE_EXPORT LayoutFileUploadControl final : public LayoutBlockFlow {
PhysicalRect OverflowClipRect(const PhysicalOffset&, PhysicalRect OverflowClipRect(const PhysicalOffset&,
OverlayScrollbarClipBehavior) const override; OverlayScrollbarClipBehavior) const override;
bool PaintedOutputOfObjectHasNoEffectRegardlessOfSize() const override {
return false;
}
static const int kAfterButtonSpacing = 4; static const int kAfterButtonSpacing = 4;
const char* GetName() const override { return "LayoutFileUploadControl"; } const char* GetName() const override { return "LayoutFileUploadControl"; }
......
third_party/blink/web_tests/paint/input/file-input-display-flex-crash.html 0 → 100644
View file @ 44f1ce3d
<!DOCTYPE html>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script>test(function(){});</script>
<input type="file" style="display: flex">
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment