Commit 4500dfee authored by Tibor Goldschwendt's avatar Tibor Goldschwendt Committed by Commit Bot

[webui][ntp] Fix logo / doodle alignment

cf513307 shifted the logo and doodle
down. Restore the previous alignment.

Fixed: 1104346
Change-Id: Id012b14069e80afe627ff1a9b65b8054eb874af1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293106
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: default avatarMoe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787868}
parent 33298d59
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
display: flex; display: flex;
flex-direction: column; flex-direction: column;
flex-shrink: 0; flex-shrink: 0;
justify-content: center;
min-height: var(--ntp-logo-height); min-height: var(--ntp-logo-height);
} }
......
...@@ -354,6 +354,25 @@ function createSuite(themeModeDoodlesEnabled) { ...@@ -354,6 +354,25 @@ function createSuite(themeModeDoodlesEnabled) {
assertStyle($$(logo, '#logo'), 'background-image', 'none'); assertStyle($$(logo, '#logo'), 'background-image', 'none');
}); });
test('logo aligned correctly', async () => {
// Act.
const logo = await createLogo();
// Assert.
const pos = getRelativePosition($$(logo, '#logo'), logo);
assertEquals(108, pos.top);
assertEquals(92, $$(logo, '#logo').offsetHeight);
});
test('doodle aligned correctly', async () => {
// Act.
const logo = await createLogo(createImageDoodle());
// Assert.
const pos = getRelativePosition($$(logo, '#doodle'), logo);
assertEquals(0, pos.top);
});
// Disabled for flakiness, see https://crbug.com/1065812. // Disabled for flakiness, see https://crbug.com/1065812.
test.skip('receiving resize message resizes doodle', async () => { test.skip('receiving resize message resizes doodle', async () => {
// Arrange. // Arrange.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment