desktop-pwas: Add Feature and Flag for windowing related features

This flag will be used to develop new windowing related behavior for
Desktop PWAs.

Bug: 729923
Change-Id: I594eadbdf9f00928e9c1963f510e4b7c7b7788f7
Reviewed-on: https://chromium-review.googlesource.com/566263
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485874}

chrome/browser/about_flags.cc

@@ -2020,6 +2020,10 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kBypassAppBannerEngagementChecksName,
      flag_descriptions::kBypassAppBannerEngagementChecksDescription, kOsAll,
      SINGLE_VALUE_TYPE(switches::kBypassAppBannerEngagementChecks)},
+    {"enable-desktop-pwa-windowing",
+     flag_descriptions::kEnableDesktopPWAWindowingName,
+     flag_descriptions::kEnableDesktopPWAWindowingDescription, kOsDesktop,
+     FEATURE_VALUE_TYPE(features::kDesktopPWAWindowing)},
     {"use-sync-sandbox", flag_descriptions::kSyncSandboxName,
      flag_descriptions::kSyncSandboxDescription, kOsAll,
      SINGLE_VALUE_TYPE_AND_VALUE(

chrome/browser/extensions/extension_util.cc

@@ -309,7 +309,8 @@ bool IsNewBookmarkAppsEnabled() {
 bool CanHostedAppsOpenInWindows() {
 #if defined(OS_MACOSX)
   return base::CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kEnableHostedAppsInWindows);
+             switches::kEnableHostedAppsInWindows) ||
+         base::FeatureList::IsEnabled(features::kDesktopPWAWindowing);
 #else
   return true;
 #endif

chrome/browser/flag_descriptions.cc

@@ -287,6 +287,11 @@ const char kEnableDataReductionProxySavingsPromoDescription[] =
     "saved 1 MB of data, then the promo will not be shown. Data Saver must be "
     "enabled for the promo to be shown.";
 
+const char kEnableDesktopPWAWindowingName[] =
+    "Windowing related features for desktop PWAs.";
+const char kEnableDesktopPWAWindowingDescription[] =
+    "Enable experimental windowing features for desktop PWAs.";
+
 const char kEnableEnumeratingAudioDevicesName[] =
     "Experimentally enable enumerating audio devices.";
 const char kEnableEnumeratingAudioDevicesDescription[] =

chrome/browser/flag_descriptions.h

@@ -197,6 +197,9 @@ extern const char kEnableDataReductionProxyServerExperimentDescription[];
 extern const char kEnableDataReductionProxySavingsPromoName[];
 extern const char kEnableDataReductionProxySavingsPromoDescription[];
 
+extern const char kEnableDesktopPWAWindowingName[];
+extern const char kEnableDesktopPWAWindowingDescription[];
+
 extern const char kEnableEnumeratingAudioDevicesName[];
 extern const char kEnableEnumeratingAudioDevicesDescription[];
 

chrome/common/chrome_features.cc

@@ -144,6 +144,10 @@ const base::Feature kDesktopIOSPromotion{"DesktopIOSPromotion",
                                          base::FEATURE_DISABLED_BY_DEFAULT};
 #endif
 
+// Enables or disables windowing related features for desktop PWAs.
+const base::Feature kDesktopPWAWindowing{"DesktopPWAWindowing",
+                                         base::FEATURE_DISABLED_BY_DEFAULT};
+
 // Experiment to display a toggle allowing users to opt-out of persisting a
 // Grant or Deny decision in a permission prompt.
 const base::Feature kDisplayPersistenceToggleInPermissionPrompts{

chrome/common/chrome_features.h

@@ -81,6 +81,8 @@ extern const base::Feature kCopylessPaste;
 extern const base::Feature kDesktopIOSPromotion;
 #endif  // defined(OS_WIN)
 
+extern const base::Feature kDesktopPWAWindowing;
+
 extern const base::Feature kDisplayPersistenceToggleInPermissionPrompts;
 
 extern const base::Feature kExpectCTReporting;

tools/metrics/histograms/enums.xml

@@ -22766,6 +22766,7 @@ from previous Chrome versions.
   <int value="-856016114" label="NTPOfflinePages:disabled"/>
   <int value="-855130893" label="enable-touch-calibration-setting"/>
   <int value="-853594220" label="disable-new-avatar-menu"/>
+  <int value="-848691867" label="DesktopPWAWindowing:enabled"/>
   <int value="-844537521" label="HttpFormWarning:disabled"/>
   <int value="-842438090" label="enable-md-feedback"/>
   <int value="-836123854" label="wallet-service-use-sandbox"/>
@@ -22958,6 +22959,7 @@ from previous Chrome versions.
   <int value="-146552997" label="enable-affiliation-based-matching"/>
   <int value="-144134779" label="AndroidPayIntegrationV2:disabled"/>
   <int value="-143382681" label="InstantTethering:enabled"/>
+  <int value="-138983372" label="DesktopPWAWindowing:disabled"/>
   <int value="-138773929" label="PassiveDocumentEventListeners:enabled"/>
   <int value="-122492389" label="enable-browser-task-scheduler"/>
   <int value="-119055644" label="GenericSensor:enabled"/>