Commit 450cae4a authored by Saurabh Nijhara's avatar Saurabh Nijhara Committed by Commit Bot

Fix Regression failure on Multiprofile screen.

In case of multipofile mode, when account picker is invoked a blank
white screen appears. Though it is not entirely clear why it happens,
but removing 'full-screen-dialog' attribute from the oobe-dialogs in
checking_downloading_update polymer element apparently fixes it. This
leads to another problem of the update_screen not shown in full screen
mode. For that we need to call onBeforeShow() of the polymer element
explicitly so that the oobe_dialog_host_behavior in the
checking_downlaoding_update can be used to set full screen mode for
all the oobe dialogs.

Bug: 1061330
Change-Id: Ic51082b0694f4bed0f357ec7616ab2fbc108fcb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105316Reviewed-by: default avatarDenis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Cr-Commit-Position: refs/heads/master@{#750905}
parent 79250b0a
...@@ -44,8 +44,7 @@ ...@@ -44,8 +44,7 @@
<link rel="stylesheet" href="checking_downloading_update.css"> <link rel="stylesheet" href="checking_downloading_update.css">
<oobe-dialog hidden="[[!checkingForUpdate]]" <oobe-dialog hidden="[[!checkingForUpdate]]"
title-key="checkingForUpdates" title-key="checkingForUpdates"
aria-live="polite" id="checking-for-updates-dialog" footer-shrinkable aria-live="polite" id="checking-for-updates-dialog" footer-shrinkable>
full-screen-dialog>
<hd-iron-icon slot="oobe-icon" <hd-iron-icon slot="oobe-icon"
icon1x="oobe-32:googleg" icon2x="oobe-64:googleg"> icon1x="oobe-32:googleg" icon2x="oobe-64:googleg">
</hd-iron-icon> </hd-iron-icon>
...@@ -70,7 +69,7 @@ ...@@ -70,7 +69,7 @@
title-key="updatingScreenTitle" title-key="updatingScreenTitle"
hidden="[[isCheckingOrUpdateCompleted_(checkingForUpdate, hidden="[[isCheckingOrUpdateCompleted_(checkingForUpdate,
updateCompleted)]]" updateCompleted)]]"
aria-live="polite" full-screen-dialog> aria-live="polite">
<hd-iron-icon slot="oobe-icon" <hd-iron-icon slot="oobe-icon"
icon1x="oobe-32:googleg" icon2x="oobe-64:googleg"> icon1x="oobe-32:googleg" icon2x="oobe-64:googleg">
</hd-iron-icon> </hd-iron-icon>
...@@ -97,7 +96,7 @@ ...@@ -97,7 +96,7 @@
<oobe-dialog footer-shrinkable id="update-complete-dialog" <oobe-dialog footer-shrinkable id="update-complete-dialog"
hidden="[[!updateCompleted]]" subtitle-key="updateCompeletedMsg" hidden="[[!updateCompleted]]" subtitle-key="updateCompeletedMsg"
aria-live="polite" full-screen-dialog> aria-live="polite">
<hd-iron-icon slot="oobe-icon" <hd-iron-icon slot="oobe-icon"
icon1x="oobe-32:googleg" icon2x="oobe-64:googleg"> icon1x="oobe-32:googleg" icon2x="oobe-64:googleg">
</hd-iron-icon> </hd-iron-icon>
......
...@@ -90,6 +90,7 @@ Polymer({ ...@@ -90,6 +90,7 @@ Polymer({
if (behavior.onBeforeShow) if (behavior.onBeforeShow)
behavior.onBeforeShow.call(this); behavior.onBeforeShow.call(this);
}); });
this.$['checking-downloading-update'].onBeforeShow();
}, },
onBackClicked_() { onBackClicked_() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment