Commit 451a6636 authored by tfarina's avatar tfarina Committed by Commit bot

rlz: get rid of the call to AppendHeaderIfMissing()

When |rlz_string| is non-empty, we can build the header and simply
return it ourselves.

This will help us to fix the Darin's TODO in HttpUtil to remove
HasHeader() method.

BUG=None
TEST=components_unittests
R=mmenke@chromium.org,rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2621843002
Cr-Commit-Position: refs/heads/master@{#442616}
parent 2d67dc21
...@@ -14,11 +14,11 @@ ...@@ -14,11 +14,11 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/message_loop/message_loop.h" #include "base/message_loop/message_loop.h"
#include "base/strings/string_util.h" #include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "base/trace_event/trace_event.h" #include "base/trace_event/trace_event.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "components/rlz/rlz_tracker_delegate.h" #include "components/rlz/rlz_tracker_delegate.h"
#include "net/http/http_util.h"
namespace rlz { namespace rlz {
namespace { namespace {
...@@ -443,9 +443,8 @@ std::string RLZTracker::GetAccessPointHttpHeader(rlz_lib::AccessPoint point) { ...@@ -443,9 +443,8 @@ std::string RLZTracker::GetAccessPointHttpHeader(rlz_lib::AccessPoint point) {
base::string16 rlz_string; base::string16 rlz_string;
RLZTracker::GetAccessPointRlz(point, &rlz_string); RLZTracker::GetAccessPointRlz(point, &rlz_string);
if (!rlz_string.empty()) { if (!rlz_string.empty()) {
net::HttpUtil::AppendHeaderIfMissing("X-Rlz-String", return base::StringPrintf("X-Rlz-String: %s\r\n",
base::UTF16ToUTF8(rlz_string), base::UTF16ToUTF8(rlz_string).c_str());
&extra_headers);
} }
return extra_headers; return extra_headers;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment