Commit 451b82cd authored by Darren Shen's avatar Darren Shen Committed by Commit Bot

Remove the need for field_size for storage_only when type_name is bool.

Currently, all boolean storage_only fields in ComputedStyle need to
specify field_size: 1. This is kind of redundant, because it will never
be any other value.

This patch removes the need to specifiy field_size for boolean
storage_only fields.

This does not change generated code.

Bug: 628043
Change-Id: Iccba6c299847c35e3a4c2fd19d4d2f9e85e3e62d
Reviewed-on: https://chromium-review.googlesource.com/544475
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: default avatarnainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481804}
parent 82e425e1
......@@ -335,10 +335,9 @@ def _create_property_field(property_):
"so it should not specify a field_size")
size = int(math.ceil(math.log(len(property_['keywords']), 2)))
elif property_['field_template'] == 'storage_only':
# 'storage_only' fields need to specify a size, type_name and default_value
type_name = property_['type_name']
default_value = property_['default_value']
size = property_['field_size']
size = 1 if type_name == 'bool' else property_['field_size']
elif property_['field_template'] == 'external':
type_name = property_['type_name']
default_value = property_['default_value']
......
......@@ -155,7 +155,6 @@
{
name: "EmptyState",
field_template: "storage_only",
field_size: 1,
default_value: "false",
type_name: "bool",
custom_copy: true,
......@@ -183,7 +182,6 @@
{
name: "HasSimpleUnderline",
field_template: "storage_only",
field_size: 1,
default_value: "false",
type_name: "bool",
inherited: true,
......@@ -242,7 +240,6 @@
name: "HasAutoClip",
field_template: "storage_only",
type_name: "bool",
field_size: 1,
default_value: "true",
field_group: "visual",
},
......@@ -250,7 +247,6 @@
name: "HasAutoZIndex",
field_template: "storage_only",
type_name: "bool",
field_size: 1,
field_group: "box",
default_value: "true",
},
......@@ -349,7 +345,6 @@
field_template: "storage_only",
type_name: "bool",
default_value: "true",
field_size: 1,
field_group: "rare-inherited",
},
{
......@@ -358,7 +353,6 @@
field_template: "storage_only",
type_name: "bool",
default_value: "true",
field_size: 1,
field_group: "rare-inherited",
},
{
......@@ -367,7 +361,6 @@
field_template: "storage_only",
type_name: "bool",
default_value: "true",
field_size: 1,
field_group: "rare-inherited",
},
{
......@@ -376,7 +369,6 @@
field_template: "storage_only",
type_name: "bool",
default_value: "false",
field_size: 1,
field_group: "rare-inherited",
},
{
......@@ -385,7 +377,6 @@
field_template: "storage_only",
type_name: "bool",
default_value: "true",
field_size: 1,
field_group: "rare-inherited",
},
{
......@@ -394,7 +385,6 @@
field_template: "storage_only",
type_name: "bool",
default_value: "true",
field_size: 1,
field_group: "rare-inherited",
},
{
......@@ -403,7 +393,6 @@
field_template: "storage_only",
type_name: "bool",
default_value: "true",
field_size: 1,
field_group: "rare-inherited",
},
{
......@@ -412,7 +401,6 @@
field_template: "storage_only",
type_name: "bool",
default_value: "true",
field_size: 1,
field_group: "rare-inherited",
},
{
......@@ -421,7 +409,6 @@
field_template: "storage_only",
type_name: "bool",
default_value: "false",
field_size: 1,
field_group: "rare-inherited",
},
{
......@@ -430,7 +417,6 @@
field_template: "storage_only",
type_name: "bool",
default_value: "true",
field_size: 1,
field_group: "rare-inherited",
},
{
......@@ -495,7 +481,6 @@
field_template: "primitive",
type_name: "bool",
default_value: "false",
field_size: 1,
field_group: "rare-inherited",
},
{
......@@ -865,7 +850,6 @@
type_name: "bool",
field_group: "rare-non-inherited->multi-col",
default_value: "true",
field_size: 1,
},
{
name: "ColumnAutoCount",
......@@ -873,7 +857,6 @@
type_name: "bool",
field_group: "rare-non-inherited->multi-col",
default_value: "true",
field_size: 1,
},
{
name: "ColumnNormalGap",
......@@ -881,7 +864,6 @@
type_name: "bool",
field_group: "rare-non-inherited->multi-col",
default_value: "true",
field_size: 1,
},
{
name: "TransformOperations",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment