Parameterized CharacterIteratorTest for LayoutNG

This patch parameterizes CharacterIteratorTest for LayoutNG to prevent
regressions when LayoutNG is enabled.

Bug: 810579
Change-Id: I160081c9389aed9ee8cb326be6e022d7b6fd375f
Reviewed-on: https://chromium-review.googlesource.com/c/1340271Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608916}

third_party/blink/renderer/core/editing/iterators/character_iterator_test.cc

@@ -33,12 +33,28 @@
 #include "third_party/blink/renderer/core/editing/ephemeral_range.h"
 #include "third_party/blink/renderer/core/editing/testing/editing_test_base.h"
 #include "third_party/blink/renderer/core/frame/local_frame_view.h"
+#include "third_party/blink/renderer/platform/testing/runtime_enabled_features_test_helpers.h"
 
 namespace blink {
 
 class CharacterIteratorTest : public EditingTestBase {};
 
-TEST_F(CharacterIteratorTest, SubrangeWithReplacedElements) {
+class ParameterizedCharacterIteratorTest
+    : public testing::WithParamInterface<bool>,
+      private ScopedLayoutNGForTest,
+      public CharacterIteratorTest {
+ public:
+  ParameterizedCharacterIteratorTest() : ScopedLayoutNGForTest(GetParam()) {}
+
+ protected:
+  bool LayoutNGEnabled() const { return GetParam(); }
+};
+
+INSTANTIATE_TEST_CASE_P(All,
+                        ParameterizedCharacterIteratorTest,
+                        testing::Bool());
+
+TEST_P(ParameterizedCharacterIteratorTest, SubrangeWithReplacedElements) {
   static const char* body_content =
       "<div id='div' contenteditable='true'>1<img src='foo.png'>345</div>";
   SetBodyContent(body_content);
@@ -54,7 +70,7 @@ TEST_F(CharacterIteratorTest, SubrangeWithReplacedElements) {
   EXPECT_EQ(Position(text_node, 3), result.EndPosition());
 }
 
-TEST_F(CharacterIteratorTest, CollapsedSubrange) {
+TEST_P(ParameterizedCharacterIteratorTest, CollapsedSubrange) {
   static const char* body_content =
       "<div id='div' contenteditable='true'>hello</div>";
   SetBodyContent(body_content);
@@ -72,7 +88,7 @@ TEST_F(CharacterIteratorTest, CollapsedSubrange) {
   EXPECT_EQ(Position(text_node, 3), result.EndPosition());
 }
 
-TEST_F(CharacterIteratorTest, GetPositionWithBlock) {
+TEST_P(ParameterizedCharacterIteratorTest, GetPositionWithBlock) {
   SetBodyContent("a<div>b</div>c");
 
   const Element& body = *GetDocument().body();
@@ -126,7 +142,7 @@ TEST_F(CharacterIteratorTest, GetPositionWithBlock) {
   EXPECT_TRUE(it.AtEnd());
 }
 
-TEST_F(CharacterIteratorTest, GetPositionWithBlocks) {
+TEST_P(ParameterizedCharacterIteratorTest, GetPositionWithBlocks) {
   SetBodyContent("<p id=a>b</p><p id=c>d</p>");
 
   const Element& body = *GetDocument().body();
@@ -173,7 +189,7 @@ TEST_F(CharacterIteratorTest, GetPositionWithBlocks) {
   EXPECT_TRUE(it.AtEnd());
 }
 
-TEST_F(CharacterIteratorTest, GetPositionWithBR) {
+TEST_P(ParameterizedCharacterIteratorTest, GetPositionWithBR) {
   SetBodyContent("a<br>b");
 
   const Element& body = *GetDocument().body();
@@ -212,7 +228,8 @@ TEST_F(CharacterIteratorTest, GetPositionWithBR) {
   EXPECT_TRUE(it.AtEnd());
 }
 
-TEST_F(CharacterIteratorTest, GetPositionWithCollapsedWhitespaces) {
+TEST_P(ParameterizedCharacterIteratorTest,
+       GetPositionWithCollapsedWhitespaces) {
   SetBodyContent("a <div> b </div> c");
 
   const Element& body = *GetDocument().body();
@@ -266,6 +283,7 @@ TEST_F(CharacterIteratorTest, GetPositionWithCollapsedWhitespaces) {
   EXPECT_TRUE(it.AtEnd());
 }
 
+// TODO(xiaochengh): Fix it in LayoutNG
 TEST_F(CharacterIteratorTest, GetPositionWithEmitChar16Before) {
   InsertStyleElement("b { white-space: pre; }");
   SetBodyContent("a   <b> c</b>");