Commit 4523ec57 authored by rajendrant's avatar rajendrant Committed by Commit Bot

Fix image compression test flakes

Could not repro the flakes. But from flake logs tentatively adding a
wait for ukm metrics.

Fixed: 1050728, 1063736
Change-Id: If494242b4bf0dce8afc472b9100db00f08b42fc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130768
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: default avatarMichael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756009}
parent 2b480c04
...@@ -967,7 +967,7 @@ IN_PROC_BROWSER_TEST_F(SubresourceRedirectBrowserTest, ...@@ -967,7 +967,7 @@ IN_PROC_BROWSER_TEST_F(SubresourceRedirectBrowserTest,
// This test verifies that the image redirect to lite page is disabled via // This test verifies that the image redirect to lite page is disabled via
// finch, and only the coverage metrics are recorded. // finch, and only the coverage metrics are recorded.
IN_PROC_BROWSER_TEST_F(RedirectDisabledSubresourceRedirectBrowserTest, IN_PROC_BROWSER_TEST_F(RedirectDisabledSubresourceRedirectBrowserTest,
ImagesNotRedirected) { DISABLE_ON_WIN_MAC_CHROMEOS(ImagesNotRedirected)) {
EnableDataSaver(true); EnableDataSaver(true);
CreateUkmRecorder(); CreateUkmRecorder();
SetUpPublicImageURLPaths("/load_image/image_delayed_load.html", SetUpPublicImageURLPaths("/load_image/image_delayed_load.html",
...@@ -1141,7 +1141,7 @@ IN_PROC_BROWSER_TEST_F( ...@@ -1141,7 +1141,7 @@ IN_PROC_BROWSER_TEST_F(
// Disabled due to flakes. See https://crbug.com/1063736. // Disabled due to flakes. See https://crbug.com/1063736.
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
SubresourceRedirectBrowserTest, SubresourceRedirectBrowserTest,
DISABLED_TestCSSBackgroundImageRedirect) { DISABLE_ON_WIN_MAC_CHROMEOS(TestCSSBackgroundImageRedirect)) {
EnableDataSaver(true); EnableDataSaver(true);
CreateUkmRecorder(); CreateUkmRecorder();
SetUpPublicImageURLPaths("/load_image/css_background_image.html", SetUpPublicImageURLPaths("/load_image/css_background_image.html",
...@@ -1164,6 +1164,7 @@ IN_PROC_BROWSER_TEST_F( ...@@ -1164,6 +1164,7 @@ IN_PROC_BROWSER_TEST_F(
net::HTTP_TEMPORARY_REDIRECT, 1); net::HTTP_TEMPORARY_REDIRECT, 1);
EXPECT_EQ(request_url().port(), compression_url().port()); EXPECT_EQ(request_url().port(), compression_url().port());
WaitForImageCompressionUkmMetrics(1);
VerifyCompressibleImageUkm(1); VerifyCompressibleImageUkm(1);
VerifyIneligibleImageHintsUnavailableUkm(0); VerifyIneligibleImageHintsUnavailableUkm(0);
VerifyIneligibleMissingInImageHintsUkm(0); VerifyIneligibleMissingInImageHintsUkm(0);
...@@ -1175,8 +1176,9 @@ IN_PROC_BROWSER_TEST_F( ...@@ -1175,8 +1176,9 @@ IN_PROC_BROWSER_TEST_F(
// Disabling for all as it was already Disabled on Mac, Win and ChromeOS and it // Disabling for all as it was already Disabled on Mac, Win and ChromeOS and it
// now seems to be flaky on Linux // now seems to be flaky on Linux
// Disabled due to flakes. See https://crbug.com/1063736. // Disabled due to flakes. See https://crbug.com/1063736.
IN_PROC_BROWSER_TEST_F(RedirectDisabledSubresourceRedirectBrowserTest, IN_PROC_BROWSER_TEST_F(
DISABLED_TestCSSBackgroundImageRedirect) { RedirectDisabledSubresourceRedirectBrowserTest,
DISABLE_ON_WIN_MAC_CHROMEOS(TestCSSBackgroundImageRedirect)) {
EnableDataSaver(true); EnableDataSaver(true);
CreateUkmRecorder(); CreateUkmRecorder();
SetUpPublicImageURLPaths("/load_image/css_background_image.html", SetUpPublicImageURLPaths("/load_image/css_background_image.html",
...@@ -1197,6 +1199,7 @@ IN_PROC_BROWSER_TEST_F(RedirectDisabledSubresourceRedirectBrowserTest, ...@@ -1197,6 +1199,7 @@ IN_PROC_BROWSER_TEST_F(RedirectDisabledSubresourceRedirectBrowserTest,
histogram_tester()->ExpectTotalCount( histogram_tester()->ExpectTotalCount(
"SubresourceRedirect.DidCompress.CompressionPercent", 0); "SubresourceRedirect.DidCompress.CompressionPercent", 0);
WaitForImageCompressionUkmMetrics(1);
VerifyCompressibleImageUkm(1); VerifyCompressibleImageUkm(1);
VerifyIneligibleImageHintsUnavailableUkm(0); VerifyIneligibleImageHintsUnavailableUkm(0);
VerifyIneligibleMissingInImageHintsUkm(0); VerifyIneligibleMissingInImageHintsUkm(0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment