Commit 452fa50b authored by Ken Rockot's avatar Ken Rockot Committed by Commit Bot

Revert "Reland "[ios] add credit card test for manual fallback""

This reverts commit 965f2dd7.

Reason for revert: Still broken, unfortunately: https://crbug.com/909760

Original change's description:
> Reland "[ios] add credit card test for manual fallback"
> 
> This is a reland of 30e1dd18
> 
> Adding feature flags to slimnav.
> Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970
> 
> Original change's description:
> > [ios] add credit card test for manual fallback
> >
> > Also adds AutofillManualFallbackPhaseTwo to test bots.
> >
> > Bug: 845472
> > Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
> > Reviewed-on: https://chromium-review.googlesource.com/c/1337347
> > Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> > Commit-Queue: David Jean <djean@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#611171}
> 
> TBR=rohitrao@chromium.org
> 
> Bug: 845472,908970
> Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29
> Reviewed-on: https://chromium-review.googlesource.com/c/1352328
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611679}

TBR=rohitrao@chromium.org,bpastene@chromium.org,javierrobles@chromium.org,djean@chromium.org

Change-Id: Ie4ab90910a6c9b63c0b15044663c2dab68637ae9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 845472, 908970
Reviewed-on: https://chromium-review.googlesource.com/c/1352934Reviewed-by: default avatarKen Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#611741}
parent 4bd59ad2
...@@ -159,7 +159,7 @@ ...@@ -159,7 +159,7 @@
{ {
"app": "ios_chrome_manual_fill_egtests", "app": "ios_chrome_manual_fill_egtests",
"test args": [ "test args": [
"--enable-features=AutofillManualFallback,AutofillManualFallbackPhaseTwo,WebFrameMessaging,SlimNavigationManager" "--enable-features=AutofillManualFallback,WebFrameMessaging,SlimNavigationManager"
], ],
"device type": "iPad Air 2", "device type": "iPad Air 2",
"os": "11.4", "os": "11.4",
...@@ -250,7 +250,7 @@ ...@@ -250,7 +250,7 @@
{ {
"app": "ios_chrome_manual_fill_egtests", "app": "ios_chrome_manual_fill_egtests",
"test args": [ "test args": [
"--enable-features=AutofillManualFallback,AutofillManualFallbackPhaseTwo,WebFrameMessaging,SlimNavigationManager" "--enable-features=AutofillManualFallback,WebFrameMessaging,SlimNavigationManager"
], ],
"xctest": true, "xctest": true,
"device type": "iPad Air 2", "device type": "iPad Air 2",
...@@ -342,7 +342,7 @@ ...@@ -342,7 +342,7 @@
{ {
"app": "ios_chrome_manual_fill_egtests", "app": "ios_chrome_manual_fill_egtests",
"test args": [ "test args": [
"--enable-features=AutofillManualFallback,AutofillManualFallbackPhaseTwo,WebFrameMessaging,SlimNavigationManager" "--enable-features=AutofillManualFallback,WebFrameMessaging,SlimNavigationManager"
], ],
"xctest": true, "xctest": true,
"device type": "iPhone X", "device type": "iPhone X",
...@@ -433,7 +433,7 @@ ...@@ -433,7 +433,7 @@
{ {
"app": "ios_chrome_manual_fill_egtests", "app": "ios_chrome_manual_fill_egtests",
"test args": [ "test args": [
"--enable-features=AutofillManualFallback,AutofillManualFallbackPhaseTwo,WebFrameMessaging,SlimNavigationManager" "--enable-features=AutofillManualFallback,WebFrameMessaging,SlimNavigationManager"
], ],
"device type": "iPhone X", "device type": "iPhone X",
"os": "12.1", "os": "12.1",
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
{ {
"app": "ios_chrome_manual_fill_egtests", "app": "ios_chrome_manual_fill_egtests",
"test args": [ "test args": [
"--enable-features=AutofillManualFallback,AutofillManualFallbackPhaseTwo,WebFrameMessaging" "--enable-features=AutofillManualFallback,WebFrameMessaging"
], ],
"xctest": true "xctest": true
}, },
......
...@@ -184,7 +184,6 @@ source_set("eg_tests") { ...@@ -184,7 +184,6 @@ source_set("eg_tests") {
configs += [ "//build/config/compiler:enable_arc" ] configs += [ "//build/config/compiler:enable_arc" ]
testonly = true testonly = true
sources = [ sources = [
"card_view_controller_egtest.mm",
"keyboard_observer_egtest.mm", "keyboard_observer_egtest.mm",
"password_view_controller_egtest.mm", "password_view_controller_egtest.mm",
] ]
...@@ -193,13 +192,10 @@ source_set("eg_tests") { ...@@ -193,13 +192,10 @@ source_set("eg_tests") {
":manual_fill_ui", ":manual_fill_ui",
"//base", "//base",
"//base/test:test_support", "//base/test:test_support",
"//components/autofill/core/browser",
"//components/autofill/core/browser:test_support",
"//components/autofill/core/common", "//components/autofill/core/common",
"//components/autofill/ios/browser", "//components/autofill/ios/browser",
"//components/keyed_service/core", "//components/keyed_service/core",
"//components/password_manager/core/browser", "//components/password_manager/core/browser",
"//ios/chrome/browser/autofill",
"//ios/chrome/browser/passwords", "//ios/chrome/browser/passwords",
"//ios/chrome/browser/ui/util", "//ios/chrome/browser/ui/util",
"//ios/chrome/test/app:test_support", "//ios/chrome/test/app:test_support",
......
...@@ -20,6 +20,7 @@ class CreditCard; ...@@ -20,6 +20,7 @@ class CreditCard;
namespace manual_fill { namespace manual_fill {
extern NSString* const ManageCardsAccessibilityIdentifier; extern NSString* const ManageCardsAccessibilityIdentifier;
extern NSString* const OtherCardsAccessibilityIdentifier;
} // namespace manual_fill } // namespace manual_fill
// Object in charge of getting the cards relevant for the manual fill // Object in charge of getting the cards relevant for the manual fill
......
...@@ -703,7 +703,7 @@ ...@@ -703,7 +703,7 @@
"label": "//ios/chrome/test/earl_grey:ios_chrome_manual_fill_egtests", "label": "//ios/chrome/test/earl_grey:ios_chrome_manual_fill_egtests",
"type": "raw", "type": "raw",
"args": [ "args": [
"--enable-features=AutofillManualFallback,AutofillManualFallbackPhaseTwo,WebFrameMessaging", "--enable-features=AutofillManualFallback,WebFrameMessaging",
], ],
}, },
"ios_chrome_reading_list_egtests": { "ios_chrome_reading_list_egtests": {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment